22aa61b674
Use icons for plugin bypass and pinout
2019-08-22 21:03:44 +02:00
a0d53b81b9
Update plugin-ui related icons
2019-08-22 21:03:07 +02:00
026b74e25d
Fix potential call of uninitialized pointer function
...
_template_number can be set via sysex to an arbitrary number, this
can lead to calling a filter-function at an undefined address, usually
a segfault.
2019-08-21 03:53:46 +02:00
c38c91ddbd
Initialize variable, fix branch condition
2019-08-21 03:09:32 +02:00
e6c9bcfd07
Prefer to use API defined return status
2019-08-21 03:06:28 +02:00
df60eca33c
Initialize uninitialized variable
...
This fixes a potentially undefined branch if the USB device list is empty.
dev is NULL, the loop is never entered, 'r' isn't set.
if (!dev && !r) is undefined.
2019-08-21 03:05:17 +02:00
e9e761565b
Use Icons for plugin preset buttons.
...
This reduces the preset task-bar's min-width, useful for plugins with
narrow UIs.
2019-08-21 01:27:36 +02:00
dfa93e0b17
Tweak Ardourbutton: support (VectorIcon | Indicator)
2019-08-21 01:25:34 +02:00
1d8a6076ab
Add more vector-icons, plugin toolbar related
...
This allows to replace "Add", "Save", "Delete", "Reset", "Bypass"
text with icons.
2019-08-21 01:24:49 +02:00
a5e2012ead
Consistent preset layout
...
Use the same order as AU, VST, LV2 GUIs. Show the "modified" asterisk
left of the preset-dropdown. This avoids a blank space between the
dropdown and the Add, Save, Delete buttons.
2019-08-20 23:45:49 +02:00
2d4eb7d505
Replace OOM segfault with abort :)
2019-08-20 05:07:16 +02:00
3ccaaf1ea5
There's always a previous tempo/meter section
2019-08-20 04:53:00 +02:00
0972e9a513
Skip potential garbage midi-step
2019-08-20 04:46:42 +02:00
114b5088c7
There is always at least a tempo and meter section
2019-08-20 04:29:06 +02:00
6227dd5b04
Shuttle Surface: Fix uninitialized argument in case of incomplete state
2019-08-20 04:18:43 +02:00
f5330d763a
NO-OP: whitespace
2019-08-20 04:15:11 +02:00
73d0b6894a
Skip invalid plugin-tag spec
2019-08-20 04:15:01 +02:00
bb27d10fd4
Fix potential ambiguous state-restore
...
Don't allow uninitialized argument values in case of corrupt XML
state.
2019-08-20 04:11:32 +02:00
a1b0991d26
Fix uninitialized argument value
...
TrimDrag::aborted() -> TrimDrag::finished() -> TrimDrag::motion ()
uses event->button.state
2019-08-20 04:06:31 +02:00
2dae4fc5e1
Bundle x42-tuner, drop rule-based midifilter
2019-08-20 03:44:02 +02:00
05e0cc4035
Fix prev commit, state-restore of plugins
2019-08-20 02:06:55 +02:00
031847f88e
LV2 extension to override strict-i/o per plugin
...
This allows mono to stereo plugins to override the default
routing and forces both outputs to be connected.
2019-08-19 23:28:04 +02:00
8775087ea6
Remove explicit pulse version check (debian/wheezy builds)
2019-08-17 00:18:39 +02:00
531fa74eb1
Suffix complete hw: ID to make ALSA card names unique
2019-08-16 20:00:29 +02:00
ae2b6e6b09
Further tweaks to .pending file removal
...
* only delete it after successful save
* show unlink notification in debug-builds
2019-08-16 05:31:50 +02:00
994b59c836
Prefer implicit deletion of .pending
...
Session destruction removes ".pending", no need to explicitly delete
the file.
2019-08-16 01:55:54 +02:00
6dc8f5ed1d
Fix periodic backup saves
...
Retain ".pending" files until explicit save or session destruction.
Previously every transport-stop deleted them :(
2019-08-16 01:54:21 +02:00
c89e58046a
Fix C++98 compat
2019-08-16 01:51:51 +02:00
76048c050d
Prefer "one track per file" as default
2019-08-15 01:30:17 +02:00
316880b9cf
Don't print usage to stdout for invalid parameters
2019-08-15 01:09:26 +02:00
4aedf9c3ea
Tweak .clang-format
2019-08-13 01:06:12 +02:00
e08ab1e30a
NO-OP: clang format, comments & whitespace
2019-08-13 01:05:51 +02:00
f940cbe794
Remove unused EditorSources selection filter
2019-08-13 00:53:04 +02:00
8a9b38e540
Remove remnants of hack from 9f3f3738e7
...
This fixes multiple selection. The original code using
"selection_countdown" is no longer in place. There's no "counter" to arm.
Shift/Tab name edit works regardless.
"s/m/r" solo/mute/rec shortcuts in the treeview have been discontinued
since a long time as well. Keyboard shortcuts are per window, regardless
of grab_focus()
PS. This change makes it easier for a user to start a drag/drop
operation of multiple regions. That currently assert()s, only
the first selected region is used.
2019-08-13 00:52:21 +02:00
f8e3a1cdcd
Fix transient removal -- #7785
...
Incorrect iterators were used for user-transients.
2019-08-13 00:41:09 +02:00
12da3016e6
Remove unused EditorRoutes selection filter
2019-08-12 19:31:42 +02:00
f4897bb475
Re-order editor sidebar: prioritize "Tracks & Busses"
2019-08-12 18:36:26 +02:00
bf2ac2ee72
(RegionList) Tweak column ordering + fix translation naming
2019-08-12 18:36:23 +02:00
82ebfa75f3
Source List: Explicitly check whether a file is in the {Audio|MIDI} folder where it should be.
...
Anywhere else (even somewhere else inside the session folder) should be flagged "weird"
2019-08-12 10:48:08 -05:00
ff440276c1
Source List: Source regions can be tagged, too.
2019-08-12 10:48:08 -05:00
d67d64ea03
Add Pref to write mixer-screenshot post-export
2019-08-12 16:53:55 +02:00
f7a6661969
Consolidate: use PBD method to try hard-linking
2019-08-12 16:42:07 +02:00
ffbf40c3d1
Add PBD API to hard-link files
2019-08-12 16:41:25 +02:00
c0f0acaa9f
Allow export get_path() without format
...
This is in preparation for post-export screenshots:
A possibility to get a file-path, independent of the format.
2019-08-12 15:44:16 +02:00
98c55a30c1
NO-OP: whitespace
2019-08-12 15:39:28 +02:00
24ff4adaf9
NO-OP: mark private variables, remove cruft
2019-08-12 15:35:20 +02:00
6dcf7a4d92
Initialize some more uninitialized variables
2019-08-12 15:18:00 +02:00
98c65406e3
Prefer std::vector<> over C-style malloc/free**
...
This fixes a potential out of bounds read `if (_dbtp_plugin[c])`
if c is larger than the allocated channel count.
2019-08-12 15:02:24 +02:00
b48a3a6abb
Initialize variable
2019-08-12 14:34:33 +02:00
65dcc8fa30
Initialize variable
2019-08-12 14:34:17 +02:00
