13
0
Commit Graph

40015 Commits

Author SHA1 Message Date
9060a32c34 MIDI state trackers: dump() is const
Plus minor fixes to ::resolve_diff()
2024-10-17 07:44:30 -06:00
044aec6563 basics of MIDI clip editing notification via model swap 2024-10-17 07:44:30 -06:00
7dee98279a extend MidiModel and MIDITrigger in preparation for edit-change handling 2024-10-17 07:44:30 -06:00
5da8de05ca NO-OP: internal whitespace and newline cleanup 2024-10-17 07:44:30 -06:00
4267d5b0d7 MidiStateTracker: extend API to allow "diffs" between two MidiStateTrackers 2024-10-17 07:44:30 -06:00
4bbdbc6d13 fix handling of MIDI draw tool actions and widgets
The actions and draw_xxx values are now "static", and changes in the values are
notified via a static PBD::Signal so that each EditingContext can update the
appearance of its relevant widgets.

Note also wider use of lambdas when creating actions and menu items.
2024-10-17 07:44:30 -06:00
3224b37702 NO-OP: whitespace 2024-10-17 07:44:30 -06:00
4724683b5f fix placement of ghost note while in draw mode 2024-10-17 07:44:30 -06:00
30a7f44c12 fix geometry calculations during NoteCreateDrags.
This also only uses the draw length parameter if no motion
occured during the NoteCreateDrag. Otherwise it uses the length that was
dragged (which is subjected to a threshold).
2024-10-17 07:44:30 -06:00
dd211c4329 prefer nullptr to 0 2024-10-17 07:44:30 -06:00
71f946f3b3 move tooltip settings for EditingContext widgets to EditingContext 2024-10-17 07:44:30 -06:00
36eda47075 get temporal zoom workign in MidiCueEditor
and remove qite a bit of debug output
2024-10-17 07:44:30 -06:00
99d1a4cd9b if the Editor is not the current EditingContext, don't do Editor::escape stuff 2024-10-17 07:44:30 -06:00
033dd31ff1 fix reordering warning 2024-10-17 07:44:30 -06:00
dc44d10b48 handle Escape signal in all EditingContexts (including MidiCueEditor) 2024-10-17 07:44:30 -06:00
f2e1697058 dammit jim, it's a stack not a queue 2024-10-17 07:44:30 -06:00
280fdb6e62 virtualize EditingContext::midi_action() so that MidiCueEditor works
This makes MIDI bindings work in the cue editor, as intended.
2024-10-17 07:44:30 -06:00
afe98a6671 correctly define MIDI actions using MidiView, not MidiRegionView
The latter is derived from the former.
2024-10-17 07:44:30 -06:00
fea6c7592f NO-OP: whitespace 2024-10-17 07:44:30 -06:00
e0a5b591f8 correct errors in coordinate math when moving a mote selection
This may be the first of several instances where mixing
timeline-relative positions and global canvas coordinates leads to
problems. Let's hope there are not too many.
2024-10-17 07:44:30 -06:00
e7ae93929b correctly set timeline_origin for a MidiCueEditor
for some reason the width is different when ::set_region() is called
2024-10-17 07:44:30 -06:00
c97f4f4016 various changes to editor drag code to correctly use a bounding item 2024-10-17 07:44:30 -06:00
030052e57f don't double-apply the effect of a drag with a bounding item to _grab_y 2024-10-17 07:44:30 -06:00
a9163516d8 the horizontal position *is* the value of the horizontal adjustment.
Don't waste time getting a less accurate answer from sample_to_pixel() on
_leftmost_sample.
2024-10-17 07:44:30 -06:00
060d8c82d7 introduce concept of timeline origin to EditingContext
For the main editor, the timeline starts at the left edge of the editor
canvas. But for MidiCueEditor, we place a canvas-ified piano roll header on the
left of the canvas, so the timeline starts at some position right of that.

Note that this means that converting global canvas coordinates to timeline
coordinates is no longer guaranteed to be a 1:1 transform (it will be for
Editor, but in general for EditingContext).
2024-10-17 07:44:30 -06:00
d550292f8f additional DEBUG_TRACE (Destruction) output 2024-10-17 07:44:30 -06:00
36d0a6e908 fix dangling references to a MidiRegion and MidiTrack in a MidiView 2024-10-17 07:44:30 -06:00
3aba913649 manual cleanup after another tricky rebase against master 2024-10-17 07:44:30 -06:00
e630051de1 more manual fixes after a substantial rebase 2024-10-17 07:44:30 -06:00
6ee97f93bb more manual fixes after a substantial rebase 2024-10-17 07:44:30 -06:00
e205bb98a1 manual fixes after a substantial rebase 2024-10-17 07:44:30 -06:00
bef7c48fe9 the state of things in pianorule, committed for travel purposes 2024-10-17 07:44:30 -06:00
48a6e8dfcf basics of autoscroll for pianoroll (mostly shared with Editor)
More work to do moving/testing pianoroll autoscroll variant back into EditingContext
and sharing it with Editor.
2024-10-17 07:44:30 -06:00
3fccf2b458 change coordinate system used for rubberband drags in piano roll 2024-10-17 07:44:30 -06:00
96ccb96b3b redesign drag API to provide a bounding item, not just "trackview only"
This allows rubberband drags on both the main editor and the separate piano roll to wokr
correctly.
2024-10-17 07:44:30 -06:00
3422ef5c3d fix event deliver for MidiCueView
events need a non-container item to be delivered
2024-10-17 07:44:30 -06:00
14b95116e1 move various action registry stuff into EditingContext 2024-10-17 07:44:30 -06:00
e7731f2e89 add -D actions to gtkmm2ext 2024-10-17 07:44:30 -06:00
023c21ff58 get those MIDI tool selector menus built 2024-10-17 07:44:30 -06:00
0d01e73b86 some state mgmt for EditingContexts 2024-10-17 07:44:30 -06:00
fcf5bb88d5 cue editor/piano roll: starting to get mode buttons working and keybindings too 2024-10-17 07:44:30 -06:00
009a0e6ffb stacktraces to help track down missing actions 2024-10-17 07:44:30 -06:00
59ed3d7138 cleanup canvas piano roll header so that it can exist with no current MidiView 2024-10-17 07:44:30 -06:00
d356cacb2a working and accessible canvas cursor setting 2024-10-17 07:44:30 -06:00
7899829a5e note range for midi * views API cleanup 2024-10-17 07:44:30 -06:00
9d8ddd814c expose ::set_note_range() as public in MidiView 2024-10-17 07:44:30 -06:00
a3491a13df fix drawing translation issue 2024-10-17 07:44:30 -06:00
df25386d2f basically functioning piano roll for midi cue editor 2024-10-17 07:44:30 -06:00
f7b6a3cac8 tentative beginnings for a canvas piano roll header 2024-10-17 07:44:30 -06:00
5acedc036a fix up event handling so that MIDI note drag works in cue editor 2024-10-17 07:44:30 -06:00