13
0
Commit Graph

7887 Commits

Author SHA1 Message Date
nick_m
18c502f646 Reduce selection loss when changing mouse modes.
Never change selection when smart mode toggled.
2015-01-15 01:39:00 +11:00
nick_m
44f2f53cde A test for less brutall deselection on mouse mode change.
Mostly stops toggling smart mode from doing anything to the selection.
2015-01-15 00:06:16 +11:00
e1f8112f81 toggling smart mode is just an option.
it should not force mouse-mode to Object
it should not clear the current object selection
2015-01-14 06:30:16 -06:00
59bb3fbe65 Remove drag code from automation region view.
Let the editor handle it like (almost) everything else.
2015-01-13 23:53:28 -05:00
d39d4c1c11 Fix automation range drag and implement for MIDI.
Range select rect sticks around now after switching to the draw tool, but
disappears if a note selection is made.  Not sure if draw is really the most
appropriate tool here (particularly if we ever implement actual pencil-like
drawing); edit contents seems more appropriate but that would probably cause
more selection issues, so here we are.
2015-01-13 23:30:37 -05:00
88e6995b14 when the mouse tool changes, smart mode should have no effect on clearing selections 2015-01-13 13:33:57 -06:00
nick_m
5ef868e767 Don't reuse _optimization_iterator - fixes crash on multiple note delete undo. 2015-01-13 22:52:02 +11:00
nick_m
7a3662bc14 Fix missing selection undo for track header click and route list select. 2015-01-13 21:41:30 +11:00
877492ef8a Give tempo dialog initial focus to BPM spinner. 2015-01-13 01:00:53 -05:00
45aa1e50b7 show title bar for big clock window
fixes #6116
(on OSX and [most] Linux WMs the title-bar was implicitly present)
2015-01-12 22:55:09 +01:00
c5252599bc Don't default to grab mode when undoing selection.
I'm not sure how/why this ever happens, but it does, switching the tool when it
shouldn't, which is annoying.  I'm also not sure if this fallback is necessary
for some reason, but it seems to work fine without for me.
2015-01-12 02:31:27 -05:00
305af7a5ce Fix whitespace. 2015-01-12 02:06:40 -05:00
ba9a90b927 Merge duplicated code. 2015-01-12 02:06:40 -05:00
8b47241596 Trim include tree. 2015-01-12 02:06:35 -05:00
4438263d4d Fix crash when undoing note delete. 2015-01-12 02:03:49 -05:00
1df6931e77 Fix broken whitespace (noop). 2015-01-12 01:05:01 -05:00
cd15d27033 Put tempo lines below tracks. 2015-01-12 01:05:01 -05:00
43e58911a4 Remove unused vertical scroll group. 2015-01-12 01:05:01 -05:00
e79af77a18 Revert "hotfix z-stacking"
This reverts commit 03f0229bcf.

Mitigate the fallout from said overly aggressive revert: preserve the alpha
values to not break the color configuration for when the lines are fixed.
2015-01-12 01:03:17 -05:00
c7affd79c2 remove track-selection requirement so fit_selected_tracks works as coded. change name to fit-selection. remove action to zoom (both axes) because this can trivially be accomplished by clicking (f)it and (z)oom sequentially, and it frees a keybinding. remaining bug: Fitting a selection of MIDI regions doesnt work right 2015-01-11 11:46:36 -06:00
03f0229bcf hotfix z-stacking
This reverts commit 780c1762 and e70c9a3
Both combined introduced various bugs:

* rubberband-selection has a scroll-offset
* region drag/drop has wrong y-offset
* ranges (loop etc) are above the playhead
* possible scroll performance hit (long unclipped
  lines in h_scroll_group)

on the downside: time-grid is now no longer visible behind
the rulers. Doing that will require a different approach…
2015-01-11 14:17:47 +01:00
764aad9efe clean up whitespace & debug output in 44203ce 2015-01-11 02:56:53 +01:00
0a5d5f91c9 Raise threshold for showing ticks for a bit.
This fixes two zoom levels (the closest that shows bars, and the next closest)
that had the same tick resolution despite enough space.
2015-01-10 19:38:37 -05:00
780c17620e Raise regions about tempo lines. 2015-01-10 19:38:21 -05:00
38c2bdc856 gracefully handle missing .midnam
Fixes bug: Add a .midnam to local preferences.
use it in a session. delete the .midnam,
reload session -> crash
2015-01-10 19:31:50 +01:00
nick_m
44203ce955 Fix AutomationTrackItem rubberband click thinking it was unhandled.
Fix several other cases where a single mouse click could cause several
(not nested) selection ops.
Fix missing selection memento for midi notes and midi commands.
Rename some variables.
Fix random style issues.
2015-01-11 04:07:31 +11:00
ca7965d7aa Fix initial display of grouped MIDI region colors. 2015-01-09 17:49:16 -05:00
0d66a38e75 Use quotes to include local library headers. 2015-01-09 17:48:58 -05:00
9e0cd98ad4 fix select-all-regions-within (it used to select everything overlapped) 2015-01-09 12:21:10 -06:00
a6e45a471a make set_selection_from_region do something visible 2015-01-09 12:21:10 -06:00
5b5e105680 stash Bring Into Session inside the Cleanup submenu 2015-01-09 12:21:10 -06:00
6c2c40a698 add .m2t video extension 2015-01-09 18:05:27 +01:00
0367aa5825 remove cruft (old unused pre-git version files) 2015-01-09 06:11:57 +01:00
7235ece898 Revert "don't unpack and repack meters unnecessarily during LevelMeterBase::setup_meters()"
This reverts commit d00e035fe0.

..which introduced a bug.

Meter count and type may change when switching the meter point or simply
when selecting a different track in the editor-mixer. Additional meters
were not unpacked and remained on canvas.

Ideally we'd just remove the excess meters or meters where the type
changed, but that's far more complex than just repacking them all.
2015-01-09 06:08:15 +01:00
ccde95757d More contrast between different division lines. 2015-01-08 21:10:54 -05:00
12bf085a34 Stop showing bar lines sooner.
Not sure if this is a DPI dependent thing, but when zooming out some of the
steps had way too dense bar lines for me.
2015-01-08 21:10:13 -05:00
8d98102573 Fix show MIDI regions using track color. 2015-01-08 19:59:40 -05:00
1256a70340 Fix inactive track header color. 2015-01-08 19:22:09 -05:00
57947ff5a8 Prevent note trim to zero length (shown as stuck).
The reasonable value 1 tick doesn't seem to work here, presumably it gets lost
in rounding conversion somewhere.  Instead use a really small power of two
reciprocal.  Once we use actual beats and ticks we can fix this to be a minimum
of one tick (the actual minimum length for a note).
2015-01-08 19:13:00 -05:00
3f34f0a0a4 Fix value ramps to reach specified upper value. 2015-01-08 18:47:08 -05:00
0aeba98cb6 Clamp value spinner when valid range changes. 2015-01-08 18:46:16 -05:00
7fac335f77 Meter-like note colours, but still mostly green.
The previous colours made low velocity notes almost invisible.  This fixes that
and attempts meter-like colours where yellowish is high, but without going all
the way into red for a generally consistent range of colors.
2015-01-08 18:36:10 -05:00
1b2377e425 Use the subtlest red we have for selected tracks.
The purple doesn't match anything anymore, red is our "selected" color.
2015-01-08 18:36:10 -05:00
b3c7578b69 Use selected fill color for selected notes. 2015-01-08 18:36:10 -05:00
f7e3d1be2c change Split menu entry to say Split/Separate (it was already doing that anyway). also fix a bug so you can drag the playhead and split at the playhead location 2015-01-08 16:00:49 -06:00
5ab70b6822 missing parenthesis 2015-01-08 16:00:49 -06:00
76cd6236e1 temporary fix: tell the user that region name-display requires a restart of ardour 2015-01-08 16:00:49 -06:00
e0964ea69a temporarily hide the tooltip preference, until CairoWidget and CanvasItem can see the config setting. it doesnt seem to be a priority since clearly nobody is using this button 2015-01-08 16:00:48 -06:00
e70c9a3da1 Show tempo lines under marker bars. 2015-01-08 15:24:14 -05:00
fe71dd3d81 More consistent canvas base colours.
General ideas: audio is blueish, MIDI is greenish, automation track colour is a
slightly darker version of its parent track colour, canvas base is the same as
the Gtk base.
2015-01-08 14:56:47 -05:00