13
0
Commit Graph

12610 Commits

Author SHA1 Message Date
a08e7c0016 fix processor -> reconfigure I/O || process concurrency
Add a ReaderLock to Route::process_output_buffers().

But process_output_buffers() is always called with processor-lock
held. To avoid deadlocks, a processor WriterLock must always imply
a process-lock (IFF reconfigure-I/O is called with _processor_lock).

Otherwise: e.g.
*  add_processor() -> takes processor-lock. set up and activate processor.
*  simult. audio-engine process, process-lock -> call process_output_buffers() -> wait for processor-lock
*  add_processor() continues -> calls reconfigure-io -> take process-lock -> deadlock.
2014-01-12 23:13:35 +01:00
7e3282486d take process lock when adding processors:
fixes possible crash if a processor modifies port-count

1. a processor is inserted and activated with processor-lock held
2. only after that the process_lock() is taken, configure_processors() is called which reconfigures-IO

BUT if the processor that is inserted changes the channel count AND audio is processed before IOs are reconfigured
 -> possible crash (invalid port-buffers)

To reproduce: Bus1 (2in, 3out), Bus2 (2in, 3out)
- add a send from Bus1 to Bus2,
- then add a processor to Bus1, just before the send which
  increases the channel-count to 4 -> occasional crash or assert.
2014-01-12 21:47:15 +01:00
0e77e578cc VBAP panner UI tweaks:
* fix mouse-grab of sentinel
* make GUI more hemisphere like (circles at latitude)
* change alpha slightly to show signal overlap
2014-01-12 21:41:02 +01:00
83c0720645 remove VAMP and Rubberband from source tree 2014-01-12 15:40:48 -05:00
4b3feefa55 add -fvisibility=default back to cxx/cflags when building QM DSP and VAMP plugins libs, because ... ugh 2014-01-12 15:40:48 -05:00
26a9e28922 add export visibility macro 2014-01-12 15:40:48 -05:00
87009afff2 add new file 2014-01-12 15:40:48 -05:00
c3a00990b3 add missing export/visibility macro 2014-01-12 15:40:48 -05:00
0a2a6aaabb remove taglib from source tree (require external provision) 2014-01-12 15:40:48 -05:00
5062a00c7d move -fvisibility=hidden to the top of the source tree, and remove its internal use; use libtimecode as a shared lib again 2014-01-12 15:40:47 -05:00
2c21cbb044 add export/visibility macros to libtimecode and build as a shared library again 2014-01-12 15:40:47 -05:00
b7bc2dd2c6 build libsmf as a static library, since it is private to evoral and would otherwise require export visibility control
This also removes -fvisibility=hidden, a change that is taking place across the source tree and will show up in a later commit elsewhere
2014-01-12 15:40:47 -05:00
6fc1f27013 Merge branch 'windows+cc' into cairocanvas 2014-01-12 17:45:28 +00:00
61c692baa1 'libs/evoral' - Move a couple of 'IdentityConverter' functions into their own dedicated C++ source file. This allows them to be used correctly with __dllimport and __dllexport. Hopefully, this technique will also work for gcc / mingw 2014-01-12 17:40:25 +00:00
dd8ba245bb 'libs/evoral' - DLL visibility stuff and associated changes needed for building with MSVC. Currently includes debugging information and things that are just commented out until we have known compatibility with the other platforms (i.e. contains stuff to be removed at a later date) 2014-01-12 17:36:17 +00:00
1eaa30b725 aubio 3+4 compat 2014-01-12 18:11:14 +01:00
58f82b52e5 cosmetic change - properly use lilv API 2014-01-12 17:14:14 +01:00
261638a5a0 don't display elevation if panner does not support it. 2014-01-12 03:56:35 +01:00
f9b8300ec6 swap channel VBAP channel 2014-01-12 03:36:20 +01:00
bf7c6c07bf credit where credit is due for speaker-config and VBAP fixes inspiration 2014-01-12 02:05:01 +01:00
4a0bcd658c VBAP GUI object-grab & position 2014-01-12 00:57:27 +01:00
b54a231035 hide speaker-config in menu (it's not implemented yet) 2014-01-11 23:38:29 +01:00
60960280d1 redefine Pi :) 2014-01-11 23:38:28 +01:00
407eba04cf add spinbox to control width in VBAP GUI,.. 2014-01-11 23:38:28 +01:00
72cec05d46 VBAP rework (part III): fix position computation backend & GUI 2014-01-11 23:38:28 +01:00
7ac05ccfa5 update default speaker position list 2014-01-11 23:38:28 +01:00
0669bb455b VBAP GUI depends on signal-position (not parameter changes) 2014-01-11 23:38:28 +01:00
d3e1d54280 VBAP backend re-work (part two): speaker positioning
* clean up source (whitespace)
* fix speaker 3x3 matrix iteration
* update math to go along with Ardour Cartesian -- fixes rounding errors
* fix division by zero in cross_prod()
* disable old debug output

(NB PBD::spherical_to_cartesian() returns
  3.7494e-33, 6.12323e-17, 1 for azimuth 90 elevation 90 distance 1
while it should return
  0.000000, 0.000000, 1 for azimuth 90 elevation 90 distance 1
IOW  cos(90.0 * 2.0 * M_PI / 360.0) != 0
Cause unknown. This is currently worked around check in vec_length()
)
2014-01-11 23:38:27 +01:00
80127f9cca VBAP backend re-work (part one):
* fix azimuth, don't clamp but map to [0,1]
* prepare elevation (10+ speakers)
2014-01-11 23:38:27 +01:00
59631acc5f fix merge with master 2014-01-11 15:19:18 -05:00
943bcc29cc fix issues with isnan/isinf on OS X where <cmath> hides isnan/isinf and forces std::isnan/std::isinf 2014-01-11 15:02:10 -05:00
cf0f985bc4 avoid apple gcc warning 2014-01-11 15:01:29 -05:00
72d8ca89e2 Support midnam controller value labels. 2014-01-10 20:51:54 -05:00
0fe968a140 Fix whitespace (no functional changes). 2014-01-10 20:51:54 -05:00
658bb3ccd4 finished merge of cairocanvas with windows and windows+cc branches 2014-01-10 17:11:10 -05:00
3020b224fa Merge windows+cc branch into cairocanvas branch. Not finished, need to now merge windows branch to get changes from there 2014-01-10 16:07:57 -05:00
d15fda6d75 fix merge errors with master 2014-01-10 14:53:03 -05:00
22c303d8f6 final (?) tweaks to rectangle rendering 2014-01-10 14:36:05 -05:00
9df593d823 clamp expose (queue_redraw()) requests to visible window area, some extra debugging details 2014-01-10 14:35:36 -05:00
0bdf4c25cf fix panner search path 2014-01-10 20:35:32 +01:00
23b3816651 remove unnecessary pixel placement stuff from editor cursor 2014-01-10 14:33:50 -05:00
02e6d14e23 make no-zero-line be the default for wave views (still shown for normal audio region views 2014-01-10 12:08:58 -05:00
5154f58caa fix thinko related to streamview construction that caused bad placement/display of MIDI automation/CC tracks 2014-01-10 12:08:17 -05:00
aa1933ef8a fix up construction and outlining for automation time axis (track) base rect 2014-01-10 12:06:07 -05:00
7970437975 tweak pixel-level dimensions and positioning 2014-01-10 11:56:55 -05:00
19bd344c33 indentation 2014-01-10 11:56:15 -05:00
dca2c19ef5 regionviews used for (MIDI) automation (CC) should not show a name highlight 2014-01-10 11:55:19 -05:00
395c3d35d1 tweak up pixel-level positioning 2014-01-10 11:54:32 -05:00
6d4c0baad3 fix up thinko in recent raise_to_top/lower_to_bottom optimization 2014-01-10 11:54:05 -05:00
70c4a5e2d6 slightly expand CanvasRender debug output 2014-01-10 11:02:34 -05:00