From fc731419c5a602315d52cf234c05204a371cf227 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Wed, 30 Mar 2022 15:10:18 -0600 Subject: [PATCH] fix potentially incorrect use of strncpy(3) when copying URI for ladspa preset --- libs/ardour/ladspa_plugin.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/ardour/ladspa_plugin.cc b/libs/ardour/ladspa_plugin.cc index 5c19f0cfff..8a835f2e82 100644 --- a/libs/ardour/ladspa_plugin.cc +++ b/libs/ardour/ladspa_plugin.cc @@ -796,7 +796,8 @@ lrdf_remove_preset (const char* /*source*/, const char *setting_uri) char setting_uri_copy[64]; char buf[64]; - strncpy(setting_uri_copy, setting_uri, sizeof(setting_uri_copy)); + strncpy(setting_uri_copy, setting_uri, sizeof(setting_uri_copy) - 1); + setting_uri_copy[sizeof (setting_uri_copy) - 1] = '\0'; p.subject = setting_uri_copy; strncpy(buf, LADSPA_BASE "hasPortValue", sizeof(buf));