13
0

Use Fixed-length when drawing percussive events

Previously adding percussive-hits created sustained notes
using the current grid as duration. This allowed to create
overlapping notes with the overlap not being visible.

Most hardware MIDI drumkits do send an immediate note-off event
after each hit (if they send note-offs at all).
Ardour now follows suit and does the same when using the draw/edit tool.
This commit is contained in:
Robin Gareus 2019-09-05 00:40:48 +02:00
parent 813ad4959d
commit f491d7ec71
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04

View File

@ -6818,7 +6818,7 @@ HitCreateDrag::start_grab (GdkEvent* event, Gdk::Cursor* cursor)
}
const samplepos_t start = map.sample_at_quarter_note (eqaf) - _region_view->region()->position();
Temporal::Beats length = _region_view->get_grid_beats (pf);
Temporal::Beats length = Temporal::Beats(1.0 / 32.0); /* 1/32 beat = 1/128 note */
_editor->begin_reversible_command (_("Create Hit"));
_region_view->clear_editor_note_selection();