format: Improve header robustness against #include reordering

gtk2_ardour/ghostregion.h

@@ -28,6 +28,7 @@
 #include <vector>
 #include <boost/unordered_map.hpp>
 
+#include "evoral/Note.h"
 #include "pbd/signals.h"
 
 #include "gtkmm2ext/colors.h"

gtk2_ardour/insert_remove_time_dialog.h

@@ -20,6 +20,7 @@
 #include "public_editor.h"
 #include "editing.h"
 #include "audio_clock.h"
+#include <gtkmm/comboboxtext.h>
 
 class InsertRemoveTimeDialog : public ArdourDialog
 {

gtk2_ardour/note_base.cc

@@ -29,10 +29,14 @@
 
 #include "note_base.h"
 #include "public_editor.h"
-#include "editing_syms.h"
 #include "keyboard.h"
 #include "midi_region_view.h"
 
+/* clang-format off */
+// Include last, when GRIDTYPE has been defined by editing.h via midi_region_view.h
+#include "editing_syms.h"
+/* clang-format on */
+
 using namespace std;
 using namespace Gtkmm2ext;
 using ARDOUR::MidiModel;

gtk2_ardour/playlist_selection.h

@@ -20,13 +20,11 @@
 #ifndef __ardour_gtk_playlist_selection_h__
 #define __ardour_gtk_playlist_selection_h__
 
+#include "ardour/playlist.h"
+
 #include <list>
 #include <memory>
 
-namespace ARDOUR {
-	class Playlist;
-}
-
 struct PlaylistSelection : std::list<std::shared_ptr<ARDOUR::Playlist> > {
 public:
 	const_iterator

gtk2_ardour/port_group.h

@@ -31,12 +31,12 @@
 #include <gtkmm/widget.h>
 #include <gtkmm/checkbutton.h>
 
+#include "ardour/bundle.h"
 #include "ardour/data_type.h"
 #include "ardour/types.h"
 
 namespace ARDOUR {
 	class Session;
-	class Bundle;
 	class Processor;
 	class IO;
 }

gtk2_ardour/port_matrix_grid.h

@@ -31,10 +31,6 @@
 class PortMatrix;
 class PortMatrixBody;
 
-namespace ARDOUR {
-	class Bundle;
-}
-
 /**  The grid part of the port matrix */
 class PortMatrixGrid : public PortMatrixComponent
 {

gtk2_ardour/sys_ex.h

@@ -20,12 +20,9 @@
 #ifndef __SYSEX_H__
 #define __SYSEX_H__
 
+#include "canvas/flag.h"
 #include "midi_region_view.h"
 
-namespace ArdourCanvas {
-	class Flag;
-}
-
 class SysEx
 {
 public:

libs/ardour/ardour/operations.h

@@ -18,6 +18,7 @@
  */
 
 #include "ardour/libardour_visibility.h"
+#include "pbd/properties.h"
 
 /** These are GQuarks for a subset of UI operations.  We use these
  *  so that the undo system can be queried to find out what operations

libs/ardour/ardour/route_group_member.h

@@ -21,6 +21,7 @@
 #ifndef __libardour_route_group_member_h__
 #define __libardour_route_group_member_h__
 
+#include "ardour/libardour_visibility.h"
 #include "pbd/controllable.h"
 #include "pbd/signals.h"
 

libs/ardour/ardour/session_configuration.h

@@ -24,6 +24,7 @@
 #include <map>
 #include <string>
 
+#include "ardour/types.h"
 #include "pbd/configuration.h"
 
 namespace ARDOUR {

libs/gtkmm2ext/gtkmm2ext/persistent_tooltip.h

@@ -22,6 +22,7 @@
 
 #include <sigc++/trackable.h>
 
+#include <gtkmm.h>
 #include "gtkmm2ext/visibility.h"
 
 namespace Gtkmm2ext {

libs/surfaces/us2400/control_group.h

@@ -19,6 +19,7 @@
 #ifndef __ardour_us2400_control_protocol_control_group_h__
 #define __ardour_us2400_control_protocol_control_group_h__
 
+#include <string>
 #include <vector>
 
 namespace ArdourSurface {