From ecb992de6482753f15fb1e7e5d2d5f13aaebc5d9 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 4 Jun 2021 01:43:29 +0200 Subject: [PATCH] Remove custom generic plugin UIs (a-eq) 2/2 --- libs/ardour/ardour/lv2_plugin.h | 1 - libs/ardour/ardour/plugin.h | 11 -------- libs/ardour/lv2_plugin.cc | 45 --------------------------------- 3 files changed, 57 deletions(-) diff --git a/libs/ardour/ardour/lv2_plugin.h b/libs/ardour/ardour/lv2_plugin.h index 6495db9430..f7c21b0926 100644 --- a/libs/ardour/ardour/lv2_plugin.h +++ b/libs/ardour/ardour/lv2_plugin.h @@ -85,7 +85,6 @@ class LIBARDOUR_API LV2Plugin : public ARDOUR::Plugin, public ARDOUR::Workee std::string get_parameter_docs(uint32_t which) const; int get_parameter_descriptor (uint32_t which, ParameterDescriptor&) const; uint32_t nth_parameter (uint32_t port, bool& ok) const; - bool get_layout (uint32_t which, UILayoutHint&) const; IOPortDescription describe_io_port (DataType dt, bool input, uint32_t id) const; diff --git a/libs/ardour/ardour/plugin.h b/libs/ardour/ardour/plugin.h index c5977326f5..7a538c7244 100644 --- a/libs/ardour/ardour/plugin.h +++ b/libs/ardour/ardour/plugin.h @@ -180,17 +180,6 @@ public: virtual void add_slave (boost::shared_ptr, bool realtime) {} virtual void remove_slave (boost::shared_ptr) {} - struct UILayoutHint { - UILayoutHint () : x0 (-1), x1 (-1), y0 (-1), y1 (-1), knob (false) { } - int x0; - int x1; - int y0; - int y1; - bool knob; - }; - - virtual bool get_layout (uint32_t which, UILayoutHint&) const { return false; } - typedef struct { unsigned char* data; int width; diff --git a/libs/ardour/lv2_plugin.cc b/libs/ardour/lv2_plugin.cc index 43826c8f3f..b103a52621 100644 --- a/libs/ardour/lv2_plugin.cc +++ b/libs/ardour/lv2_plugin.cc @@ -1288,51 +1288,6 @@ LV2Plugin::get_parameter_docs(uint32_t which) const return ""; } -bool -LV2Plugin::get_layout (uint32_t which, UILayoutHint& h) const -{ - /// TODO lookup port-properties - if (unique_id () != "urn:ardour:a-eq") { - return false; - } - h.knob = true; - switch (which) { - case 0: h.x0 = 0; h.x1 = 1; h.y0 = 2; h.y1 = 3; break; // Frequency L - case 1: h.x0 = 0; h.x1 = 1; h.y0 = 0; h.y1 = 1; break; // Gain L - case 17: h.x0 = 0; h.x1 = 1; h.y0 = 5; h.y1 = 6; break; // enable L - - case 2: h.x0 = 1; h.x1 = 3; h.y0 = 2; h.y1 = 3; break; // Frequency 1 - case 3: h.x0 = 1; h.x1 = 3; h.y0 = 0; h.y1 = 1; break; // Gain 1 - case 4: h.x0 = 1; h.x1 = 3; h.y0 = 1; h.y1 = 2; break; // Bandwidth 1 - case 18: h.x0 = 1; h.x1 = 4; h.y0 = 5; h.y1 = 6; break; // enable 1 - - case 5: h.x0 = 4; h.x1 = 6; h.y0 = 2; h.y1 = 3; break; // Frequency 2 - case 6: h.x0 = 4; h.x1 = 6; h.y0 = 0; h.y1 = 1; break; // Gain 2 - case 7: h.x0 = 4; h.x1 = 6; h.y0 = 1; h.y1 = 2; break; // Bandwidth 2 - case 19: h.x0 = 4; h.x1 = 7; h.y0 = 5; h.y1 = 6; break; // enable 2 - - case 8: h.x0 = 7; h.x1 = 9; h.y0 = 2; h.y1 = 3; break; // Frequency 3 - case 9: h.x0 = 7; h.x1 = 9; h.y0 = 0; h.y1 = 1; break; // Gain 3 - case 10: h.x0 = 7; h.x1 = 9; h.y0 = 1; h.y1 = 2; break; // Bandwidth 3 - case 20: h.x0 = 7; h.x1 = 10; h.y0 = 5; h.y1 = 6; break; // enable 3 - - case 11: h.x0 = 10; h.x1 = 12; h.y0 = 2; h.y1 = 3; break; // Frequency 4 - case 12: h.x0 = 10; h.x1 = 12; h.y0 = 0; h.y1 = 1; break; // Gain 4 - case 13: h.x0 = 10; h.x1 = 12; h.y0 = 1; h.y1 = 2; break; // Bandwidth 4 - case 21: h.x0 = 10; h.x1 = 13; h.y0 = 5; h.y1 = 6; break; // enable 4 - - case 14: h.x0 = 13; h.x1 = 14; h.y0 = 2; h.y1 = 3; break; // Frequency H - case 15: h.x0 = 13; h.x1 = 14; h.y0 = 0; h.y1 = 1; break; // Gain H - case 22: h.x0 = 13; h.x1 = 14; h.y0 = 5; h.y1 = 6; break; // enable H - - case 16: h.x0 = 14; h.x1 = 15; h.y0 = 1; h.y1 = 3; break; // Master Gain - case 23: h.x0 = 14; h.x1 = 15; h.y0 = 5; h.y1 = 6; break; // Master Enable - default: - return false; - } - return true; -} - uint32_t LV2Plugin::nth_parameter(uint32_t n, bool& ok) const {