From de0ceb1f8c8fd8e7d18b2ec69baadb1ac5ea2802 Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Wed, 15 Aug 2018 22:43:18 +0200
Subject: [PATCH] Remove plugin-manager's channel-filter

For most plugin-standards it is useless. Variable I/O is not filtered,
and many plugins also come in mono-compatible stereo-variant.
The MIDI filter never worked reliably either.
---
 gtk2_ardour/plugin_selector.cc | 47 ----------------------------------
 gtk2_ardour/plugin_selector.h  |  1 -
 2 files changed, 48 deletions(-)

diff --git a/gtk2_ardour/plugin_selector.cc b/gtk2_ardour/plugin_selector.cc
index 078c5eebd1..3f03a218e5 100644
--- a/gtk2_ardour/plugin_selector.cc
+++ b/gtk2_ardour/plugin_selector.cc
@@ -219,13 +219,6 @@ PluginSelector::PluginSelector (PluginManager& mgr)
 	_fil_creator_combo.set_text_ellipsize (Pango::ELLIPSIZE_END);
 	_fil_creator_combo.set_layout_ellipsize_width (PANGO_SCALE * 160 * UIConfiguration::instance ().get_ui_scale ());
 
-	_fil_channel_combo.append_text_item (_("Audio I/O"));
-	_fil_channel_combo.append_text_item (_("Mono Audio I/O"));
-	_fil_channel_combo.append_text_item (_("Stereo Audio I/O"));
-	_fil_channel_combo.append_text_item (_("MIDI I/O (only)"));
-	_fil_channel_combo.append_text_item (_("Show All I/O"));
-	_fil_channel_combo.set_text (_("Show All I/O"));
-
 	VBox* filter_vbox = manage (new VBox);
 	filter_vbox->pack_start (*_fil_effects_radio,     false, false);
 	filter_vbox->pack_start (*_fil_instruments_radio, false, false);
@@ -235,7 +228,6 @@ PluginSelector::PluginSelector (PluginManager& mgr)
 	filter_vbox->pack_start (*_fil_all_radio,         false, false);
 	filter_vbox->pack_start (_fil_type_combo,         false, false);
 	filter_vbox->pack_start (_fil_creator_combo,      false, false);
-	filter_vbox->pack_start (_fil_channel_combo,      false, false);
 
 	filter_vbox->set_border_width (4);
 	filter_vbox->set_spacing (4);
@@ -254,7 +246,6 @@ PluginSelector::PluginSelector (PluginManager& mgr)
 
 	_fil_type_combo.StateChanged.connect (sigc::mem_fun (*this, &PluginSelector::refill));
 	_fil_creator_combo.StateChanged.connect (sigc::mem_fun (*this, &PluginSelector::refill));
-	_fil_channel_combo.StateChanged.connect (sigc::mem_fun (*this, &PluginSelector::refill));
 
 	/* TAG entry */
 
@@ -446,42 +437,6 @@ PluginSelector::show_this_plugin (const PluginInfoPtr& info, const std::string&
 		}
 	}
 
-	/* Filter "I/O" combobox */
-
-	if (_fil_channel_combo.get_text() != _("Show All I/O") || info->reconfigurable_io ()) {
-
-#if 0
-		if (info->reconfigurable_io ()) {
-			return true; // who knows.... ?
-		}
-#endif
-
-		if (_fil_channel_combo.get_text() == _("Audio I/O")) {
-			if ((info->n_inputs.n_audio() == 0 || info->n_outputs.n_audio() == 0)) {
-				return false;
-			}
-		}
-
-		if (_fil_channel_combo.get_text() == _("Mono Audio I/O")) {
-			if (info->n_inputs.n_audio() != 1 || info->n_outputs.n_audio() != 1) {
-				return false;
-			}
-		}
-
-		if (_fil_channel_combo.get_text() == _("Stereo Audio I/O")) {
-			if (info->n_inputs.n_audio() != 2 || info->n_outputs.n_audio() != 2) {
-				return false;
-			}
-		}
-
-		if (_fil_channel_combo.get_text() == _("MIDI I/O (only)")) {
-			if ((info->n_inputs.n_audio() != 0 || info->n_outputs.n_audio() == 0)) {
-				return false;
-			}
-		}
-
-	}
-
 	return true;
 }
 
@@ -505,7 +460,6 @@ PluginSelector::set_sensitive_widgets ()
 		_inhibit_refill = true;
 		_fil_type_combo.set_sensitive(false);
 		_fil_creator_combo.set_sensitive(false);
-		_fil_channel_combo.set_sensitive(false);
 		_inhibit_refill = false;
 	} else {
 		_fil_effects_radio->set_sensitive(true);
@@ -517,7 +471,6 @@ PluginSelector::set_sensitive_widgets ()
 		_inhibit_refill = true;
 		_fil_type_combo.set_sensitive(true);
 		_fil_creator_combo.set_sensitive(true);
-		_fil_channel_combo.set_sensitive(true);
 		_inhibit_refill = false;
 	}
 	if (!search_entry.get_text().empty()) {
diff --git a/gtk2_ardour/plugin_selector.h b/gtk2_ardour/plugin_selector.h
index e80d880747..fda03c10f3 100644
--- a/gtk2_ardour/plugin_selector.h
+++ b/gtk2_ardour/plugin_selector.h
@@ -82,7 +82,6 @@ private:
 	/* combobox filters */
 	ArdourWidgets::ArdourDropdown _fil_type_combo;
 	ArdourWidgets::ArdourDropdown _fil_creator_combo;
-	ArdourWidgets::ArdourDropdown _fil_channel_combo;
 
 	PluginInterestedObject* interested_object;