ardour/livetrax
13
0
Fork 0
Code

Fix crash when testing unsupported MIDI file

Browse Source 
smf_delete() does not handle NULL, and segfaults instead.

This only crashes with optimized builds.
libsmf will call g_critical() earlier and in that case debug-builds
call UI::handle_fatal() and ask the user to "click to exit".
This commit is contained in:
Robin Gareus 2018-04-08 02:05:16 +02:00
parent 518f8108ac
commit dd5f124c60
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libs/evoral/src/SMF.cpp
View File

@ -97,10 +97,11 @@ SMF::test(const std::string& path)
smf_t* test_smf = smf_load(f);
fclose(f);
const bool success = (test_smf != NULL);
if (!test_smf) {
return false;
}
smf_delete(test_smf);
return success;
return true;
}
/** Attempt to open the SMF file for reading and/or writing.