ardour/livetrax
13
0
Fork 0
Code

Only enable RegionFX in debug builds for the time being

Browse Source 
This reverts commit 14ff2f2e68.
This commit is contained in:
Robin Gareus 2024-10-16 18:29:37 +02:00
parent 6149771910
commit d525f8d60c
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/audio_region_editor.cc
View File

@ -98,6 +98,7 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv)
_table.attach (_fade_before_fx_toggle, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL); _table.attach (_fade_before_fx_toggle, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
++_table_row; ++_table_row;
#ifndef NDEBUG // disable region Fx for now
_region_line_label.set_name ("AudioRegionEditorLabel"); _region_line_label.set_name ("AudioRegionEditorLabel");
_region_line_label.set_text (_("Region Line:")); _region_line_label.set_text (_("Region Line:"));
_region_line_label.set_alignment (1, 0.5); _region_line_label.set_alignment (1, 0.5);
@ -105,6 +106,7 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv)
_table.attach (_region_line, 1, 2, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL); _table.attach (_region_line, 1, 2, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
_table.attach (_show_on_touch, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL); _table.attach (_show_on_touch, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL);
++_table_row; ++_table_row;
#endif
UI::instance()->set_tip (_polarity_toggle, _("Invert the signal polarity (180deg phase shift)")); UI::instance()->set_tip (_polarity_toggle, _("Invert the signal polarity (180deg phase shift)"));
UI::instance()->set_tip (_fade_before_fx_toggle, _("Apply region effects after the region fade.\nThis is useful if the effect(s) have tail, which would otherwise be faded out by the region fade (e.g. reverb, delay)")); UI::instance()->set_tip (_fade_before_fx_toggle, _("Apply region effects after the region fade.\nThis is useful if the effect(s) have tail, which would otherwise be faded out by the region fade (e.g. reverb, delay)"));

4
gtk2_ardour/region_editor.cc
View File

@ -187,8 +187,10 @@ RegionEditor::RegionEditor (Session* s, RegionView* rv)
_table.attach (_sources, 1, 2, _table_row, _table_row + 1, Gtk::FILL | Gtk::EXPAND, Gtk::FILL); _table.attach (_sources, 1, 2, _table_row, _table_row + 1, Gtk::FILL | Gtk::EXPAND, Gtk::FILL);
++_table_row; ++_table_row;
#ifndef NDEBUG // disable region FX for now
_table.attach (region_fx_label, 2, 3, 0, 1, Gtk::FILL, Gtk::FILL); _table.attach (region_fx_label, 2, 3, 0, 1, Gtk::FILL, Gtk::FILL);
_table.attach (_region_fx_box, 2, 3, 1, _table_row + 2, Gtk::FILL, Gtk::FILL); _table.attach (_region_fx_box, 2, 3, 1, _table_row + 2, Gtk::FILL, Gtk::FILL);
#endif
get_vbox()->pack_start (_table, true, true); get_vbox()->pack_start (_table, true, true);
@ -230,11 +232,13 @@ RegionEditor::RegionEditor (Session* s, RegionView* rv)
spin_arrow_grab = false; spin_arrow_grab = false;
#ifndef NDEBUG // disable region FX for now
/* for now only audio region effects are supported */ /* for now only audio region effects are supported */
if (std::dynamic_pointer_cast<AudioRegion> (_region)) { if (std::dynamic_pointer_cast<AudioRegion> (_region)) {
region_fx_label.show (); region_fx_label.show ();
_region_fx_box.show (); _region_fx_box.show ();
} }
#endif
connect_editor_events (); connect_editor_events ();
} }

2
libs/ardour/luabindings.cc
View File

@ -1654,10 +1654,12 @@ LuaBindings::common (lua_State* L)
.addFunction ("has_transients", &Region::has_transients) .addFunction ("has_transients", &Region::has_transients)
.addFunction ("transients", (AnalysisFeatureList (Region::*)())&Region::transients) .addFunction ("transients", (AnalysisFeatureList (Region::*)())&Region::transients)
#ifndef NDEBUG // disable region FX for now
.addFunction ("load_plugin", &Region::load_plugin) .addFunction ("load_plugin", &Region::load_plugin)
.addFunction ("add_plugin", &Region::add_plugin) .addFunction ("add_plugin", &Region::add_plugin)
.addFunction ("remove_plugin", &Region::add_plugin) .addFunction ("remove_plugin", &Region::add_plugin)
.addFunction ("nth_plugin", &Region::nth_plugin) .addFunction ("nth_plugin", &Region::nth_plugin)
#endif
/* editing operations */ /* editing operations */
.addFunction ("set_length", &Region::set_length) .addFunction ("set_length", &Region::set_length)