ardour/livetrax
13
0
Fork 0
Code

Fix intermittent hang when stopping PortaudioBackend

Browse Source 
This issue is not always reproducible but when it does occur it happens
somewhat consistently on both 32bit and 64bit builds(Tested on Windows 7).

The midiOutReset call does not return (or it takes so long that it might as
well be indefinite) and as it is not strictly necessary just remove it.

Resolves: http://tracker.ardour.org/view.php?id=7095
This commit is contained in:
Tim Mayberry 2016-11-15 09:19:24 +10:00
parent ea1231fb95
commit d10913e2de
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libs/backends/portaudio/winmmemidi_output_device.cc
View File

@ -118,13 +118,7 @@ WinMMEMidiOutputDevice::close (std::string& error_msg)
{
// return error message for first error encountered?
bool success = true;
MMRESULT result = midiOutReset (m_handle);
if (result != MMSYSERR_NOERROR) {
error_msg = get_error_string (result);
DEBUG_MIDI (error_msg);
success = false;
}
result = midiOutClose (m_handle);
MMRESULT result = midiOutClose (m_handle);
if (result != MMSYSERR_NOERROR) {
error_msg = get_error_string (result);
DEBUG_MIDI (error_msg);