From bec4344546dc05c290f71ec34dcf8df3c447de79 Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Fri, 27 Oct 2023 21:13:04 +0200
Subject: [PATCH] Console1: leave some TODO notes for later

---
 libs/surfaces/console1/console1.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libs/surfaces/console1/console1.h b/libs/surfaces/console1/console1.h
index 5765c7e568..c13a81b0ff 100644
--- a/libs/surfaces/console1/console1.h
+++ b/libs/surfaces/console1/console1.h
@@ -63,12 +63,20 @@ namespace ArdourSurface {
 
 class C1GUI;
 
+// XXX TODO: these classes should not be in the ArdourSurface namespace
+// which is shared with all other ctrl surfaces.
+//
+// ArdourSurface::Meter etc may cause conflicts.
+// best add a C1 prefix, or additional namespace
+
 class Controller;
 class ControllerButton;
 class MultiStateButton;
 class Meter;
 class Encoder;
 
+// 'using' in header files is frowned upon.
+// it may cause conflicts or result in amgibuities
 using Controllable = std::shared_ptr<PBD::Controllable>;
 using order_t = ARDOUR::PresentationInfo::order_t;