From ad6ddf70df5034a5b48a4bac22e9f552cf502c21 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Sat, 4 Mar 2017 17:47:57 +0100 Subject: [PATCH] Don't allow GMCP to override loading_state_version - GMPC does not use it directly - when GMPC was enabled Stateful::loading_state_version was set to 1000 (the protocol is at 1.0.0) - it messes up session-loading, particularly various plugin states and templates (e.g Processor::set_state_2X was used) --- .../surfaces/generic_midi/generic_midi_control_protocol.cc | 7 ------- 1 file changed, 7 deletions(-) diff --git a/libs/surfaces/generic_midi/generic_midi_control_protocol.cc b/libs/surfaces/generic_midi/generic_midi_control_protocol.cc index 9e9074c4c2..7f711d7afe 100644 --- a/libs/surfaces/generic_midi/generic_midi_control_protocol.cc +++ b/libs/surfaces/generic_midi/generic_midi_control_protocol.cc @@ -746,13 +746,6 @@ GenericMidiControlProtocol::load_bindings (const string& xmlpath) if ((prop = root->property ("version")) == 0) { return -1; - } else { - int major; - int minor; - int micro; - - sscanf (prop->value().c_str(), "%d.%d.%d", &major, &minor, µ); - Stateful::loading_state_version = (major * 1000) + minor; } const XMLNodeList& children (root->children());