From a58f7caca133af3ce68f9a1e6aa9c50f61a1bc28 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Tue, 6 Nov 2018 22:43:36 +0100 Subject: [PATCH] Skip updating options for hidden file-dialog This may also fix an edge-case issue where changing track selection combined with invalid file selection may trigger a bad_file_message. --- gtk2_ardour/sfdb_ui.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gtk2_ardour/sfdb_ui.cc b/gtk2_ardour/sfdb_ui.cc index fcd8510d92..2c4d5b4db6 100644 --- a/gtk2_ardour/sfdb_ui.cc +++ b/gtk2_ardour/sfdb_ui.cc @@ -855,6 +855,7 @@ void SoundFileBrowser::on_show () { ArdourWindow::on_show (); + reset_options (); start_metering (); } @@ -2028,13 +2029,15 @@ SoundFileOmega::reset (uint32_t selected_audio_tracks, uint32_t selected_midi_tr chooser.set_filter (audio_and_midi_filter); } - reset_options (); + if (is_visible()) { + reset_options (); + } } void SoundFileOmega::file_selection_changed () { - if (resetting_ourselves) { + if (resetting_ourselves || !is_visible ()) { return; }