From a568b3c7c2bc660d2f000110747534dec1ee8332 Mon Sep 17 00:00:00 2001
From: Hector Martin <marcan@marcan.st>
Date: Tue, 10 Nov 2020 20:58:53 +0900
Subject: [PATCH] Complain when MidiBuffer::merge_from fails due to buffer full

We were previously dropping MIDI data silently
---
 libs/ardour/midi_buffer.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libs/ardour/midi_buffer.cc b/libs/ardour/midi_buffer.cc
index d0e9882aeb..20331473a2 100644
--- a/libs/ardour/midi_buffer.cc
+++ b/libs/ardour/midi_buffer.cc
@@ -136,7 +136,10 @@ MidiBuffer::merge_from (const Buffer& src, samplecnt_t /*nframes*/, sampleoffset
 	assert (mbuf != this);
 
 	/* XXX use nframes, and possible offsets */
-	merge_in_place (*mbuf);
+	if (!merge_in_place (*mbuf)) {
+		cerr << string_compose ("MidiBuffer::merge_in_place failed (buffer is full: size: %1 capacity %2 new bytes %3)", _size, _capacity, mbuf->size()) << endl;
+		PBD::stacktrace (cerr, 20);
+	}
 }
 
 /** Push an event into the buffer.