ardour/livetrax
13
0
Fork 0
Code

API changes for ControlGroup::fill_from..()

Browse Source 
This reflects better/different use by callers
This commit is contained in:
Paul Davis 2023-07-31 18:30:36 -06:00
parent b338b946b8
commit a5477feb27
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/ardour/ardour/control_group.h
View File

@ -49,7 +49,7 @@ class LIBARDOUR_API ControlGroup : public std::enable_shared_from_this<ControlGr
Inverted = 0x2, Inverted = 0x2,
}; };
void fill_from_selection_or_group (std::shared_ptr<Stripable>, CoreSelection const &, Evoral::Parameter const &, bool (RouteGroup::*group_predicate)() const); void fill_from_stripable_list (StripableList&, Evoral::Parameter const &);
int add_control (std::shared_ptr<AutomationControl>, bool push = false); int add_control (std::shared_ptr<AutomationControl>, bool push = false);
int remove_control (std::shared_ptr<AutomationControl>, bool pop = false); int remove_control (std::shared_ptr<AutomationControl>, bool pop = false);

6
libs/ardour/control_group.cc
View File

@ -218,12 +218,8 @@ ControlGroup::set_group_value (std::shared_ptr<AutomationControl> control, doubl
} }
void void
ControlGroup::fill_from_selection_or_group (std::shared_ptr<Stripable> target, CoreSelection const & sel, Evoral::Parameter const & p, bool (RouteGroup::*group_predicate)() const) ControlGroup::fill_from_stripable_list (StripableList& sl, Evoral::Parameter const & p)
{ {
StripableList sl;
sel.get_stripables_for_op (sl, target, group_predicate);
/* Very unfortunate that gain control is special cased. Routes do not /* Very unfortunate that gain control is special cased. Routes do not
* call ::add_control() for their gain control, but instead pass it to * call ::add_control() for their gain control, but instead pass it to
* their Amp processor which takes a certain kind of ownership of it. * their Amp processor which takes a certain kind of ownership of it.