ardour/livetrax
13
0
Fork 0
Code

PortEngineSharedImpl callbacks should not be pure virtual

Browse Source 
A port can callback from its destructor, which if occuring inside the backend destructor
would reach an already partially destructed backend.
This commit is contained in:
Paul Davis 2020-04-07 20:36:20 -06:00
parent ede8b9995a
commit a13ef36b3b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/ardour/ardour/port_engine_shared.h
View File

@ -154,8 +154,8 @@ public:
bool physically_connected (PortEngine::PortHandle, bool process_callback_safe);
int get_connections (PortEngine::PortHandle, std::vector<std::string>&, bool process_callback_safe);
virtual void port_connect_callback (const std::string& a, const std::string& b, bool conn) = 0;
virtual void port_connect_add_remove_callback () = 0;
virtual void port_connect_callback (const std::string& a, const std::string& b, bool conn) {}
virtual void port_connect_add_remove_callback () {}
protected:
std::string _instance_name;