ardour/livetrax
13
0
Fork 0
Code

Safe config save

Browse Source 
This prevents corrupt rc-config files in case the disk is full.
This is a safeguard, since Ardour does not start if the main
config file is corrupt.
This commit is contained in:
Robin Gareus 2020-05-19 19:47:34 +02:00
parent 5b1a8f79bc
commit 97afc4dfd6
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
libs/ardour/rc_configuration.cc
View File

@ -35,6 +35,7 @@
#include "ardour/disk_reader.h"
#include "ardour/disk_writer.h"
#include "ardour/control_protocol_manager.h"
#include "ardour/filename_extensions.h"
#include "ardour/filesystem_paths.h"
#include "ardour/port.h"
#include "ardour/rc_configuration.h"
@ -149,15 +150,24 @@ int
RCConfiguration::save_state()
{
const std::string rcfile = Glib::build_filename (user_config_directory(), user_config_file_name);
const std::string tmpfile = rcfile + temp_suffix;
// this test seems bogus?
if (!rcfile.empty()) {
XMLTree tree;
tree.set_root (&get_state());
if (!tree.write (rcfile.c_str())){
error << string_compose (_("Config file %1 not saved"), rcfile) << endmsg;
return -1;
XMLTree tree;
tree.set_root (&get_state());
if (!tree.write (tmpfile.c_str())){
error << string_compose (_("Config file %1 not saved"), rcfile) << endmsg;
if (g_remove (tmpfile.c_str()) != 0) {
error << string_compose(_("Could not remove temporary config file at path \"%1\" (%2)"), tmpfile, g_strerror (errno)) << endmsg;
}
return -1;
}
if (::g_rename (tmpfile.c_str(), rcfile.c_str()) != 0) {
error << string_compose (_("Could not rename temporary config file %1 to %2 (%3)"), tmpfile, rcfile, g_strerror(errno)) << endmsg;
if (g_remove (tmpfile.c_str()) != 0) {
error << string_compose(_("Could not remove temporary config file at path \"%1\" (%2)"), tmpfile, g_strerror (errno)) << endmsg;
}
return -1;
}
return 0;