ardour/livetrax
13
0
Fork 0
Code

when recording MIDI, create active_notes on demand

Browse Source 
Since the signal handler for "data recorded" is in the GUI thread, we can do
whatever we want there, including memory allocation
This commit is contained in:
Paul Davis 2024-11-09 09:20:25 -07:00
parent a7bd0da8ea
commit 96ef4d20f2
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk2_ardour/midi_cue_editor.cc
View File

@ -501,9 +501,7 @@ MidiCueEditor::box_rec_enable_change (ARDOUR::TriggerBox const & b)
void void
MidiCueEditor::trigger_rec_enable_change (ARDOUR::Trigger const & t) MidiCueEditor::trigger_rec_enable_change (ARDOUR::Trigger const & t)
{ {
if (t.armed()) { if (!t.armed()) {
view->begin_write();
} else {
view->end_write (); view->end_write ();
} }
} }

9
gtk2_ardour/midi_view.cc
View File

@ -193,12 +193,6 @@ MidiView::set_track (std::shared_ptr<MidiTrack> mt)
if (_midi_track) { if (_midi_track) {
_midi_track->DropReferences.connect (track_going_away_connection, invalidator (*this), std::bind (&MidiView::track_going_away, this), gui_context()); _midi_track->DropReferences.connect (track_going_away_connection, invalidator (*this), std::bind (&MidiView::track_going_away, this), gui_context());
if (_needs_active_notes_for_rec_enabled_track && _midi_track->triggerbox()->record_enabled()) {
begin_write ();
} else {
end_write ();
}
} }
} }
@ -4497,8 +4491,7 @@ MidiView::clip_data_recorded (samplecnt_t total_duration)
} }
if (!_active_notes) { if (!_active_notes) {
/* we aren't actively being recorded to */ begin_write ();
return;
} }
if (_active_notes) { if (_active_notes) {