From 8a9a9695aab6bd1e8f2c7fccbc56ad06cb587629 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Tue, 10 Sep 2024 19:21:48 +0200 Subject: [PATCH] Fix crash when transport master widget is visible at session close Previously that could cause a heap-use-after-free. A reliable way to trigger it was to show the audio connection dialog and connect a track's output to LTC master, then quit. --- gtk2_ardour/transport_masters_dialog.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk2_ardour/transport_masters_dialog.cc b/gtk2_ardour/transport_masters_dialog.cc index 1a2c058ea3..58fae44b5f 100644 --- a/gtk2_ardour/transport_masters_dialog.cc +++ b/gtk2_ardour/transport_masters_dialog.cc @@ -256,7 +256,7 @@ TransportMastersWidget::rebuild () r->sclock_synced_button.signal_toggled().connect (sigc::mem_fun (*r, &TransportMastersWidget::Row::sync_button_toggled)); } - r->tm->PropertyChanged.connect (r->property_change_connection, invalidator (*this), boost::bind (&TransportMastersWidget::Row::prop_change, r, _1), gui_context()); + r->tm->PropertyChanged.connect (r->property_change_connection, invalidator (*r), boost::bind (&TransportMastersWidget::Row::prop_change, r, _1), gui_context()); PropertyChange all_change; all_change.add (Properties::locked);