ardour/livetrax
13
0
Fork 0
Code

Fix a bug where the spinner skipped values because it was always rounding down

Browse Source 
Until we have a trimmer, the clip length spinner sets integer beats (beatcnt)
This allows the user some minimal ability to fix a clip of the wrong bpm.
We assumed that 'clips' are already be pre-trimmed to a beat length.
Our internal heuristic always forced tempo to match an integer beatcnt

However: when bouncing a Range to a Trigger Clip, you can know the tempo, and also have a non-integer beat length.
In those cases, the clip-length spinner could behave oddly.

While it's arguably wrong to show integer beats when the internal value is something else,
  we still want to show the spinner in integer beats, so it remains usable for its main purpose
This commit is contained in:
Ben Loftis 2022-02-12 09:04:00 -06:00
parent d8b3fbb94e
commit 6bc881086b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/audio_trigger_properties_box.cc
View File

@ -224,7 +224,7 @@ AudioTriggerPropertiesBox::on_trigger_changed (const PBD::PropertyChange& pc)
ArdourWidgets::set_tooltip (_abpm_label, string_compose ("Clip Tempo, used for stretching. Estimated tempo (from file) was: %1", trigger->estimated_tempo ()));
int beats = at->segment_beatcnt();
int beats = round(at->segment_beatcnt());
_beat_adjustment.set_value(beats);