ardour/livetrax
13
0
Fork 0
Code

Waveview: fix rounding, span entire region rectangle

Browse Source 
Previously samples at the end could end up being cropped,
when the Waveview is rendered using an offset.
This commit is contained in:
Robin Gareus 2024-09-26 01:09:07 +02:00
parent b28090c64c
commit 68eb63e0c8
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libs/waveview/wave_view.cc
View File

@ -307,7 +307,7 @@ WaveView::get_item_and_draw_rect_in_window_coords (Rect const& canvas_rect, Rect
*/ */
double const width = region_length() / _props->samples_per_pixel; double const width = region_length() / _props->samples_per_pixel;
item_rect = item_to_window (Rect (0.0, 0.0, width, _props->height)); item_rect = item_to_window (Rect (0.0, 0.0, width, _props->height), false);
/* Now lets get the intersection with the area we've been asked to draw */ /* Now lets get the intersection with the area we've been asked to draw */
@ -318,6 +318,11 @@ WaveView::get_item_and_draw_rect_in_window_coords (Rect const& canvas_rect, Rect
return false; return false;
} }
item_rect.x0 = floor (item_rect.x0);
item_rect.x1 = ceil (item_rect.x1);
item_rect.y0 = round (item_rect.y0);
item_rect.y1 = round (item_rect.y1);
/* draw_rect now defines the rectangle we need to update/render the waveview /* draw_rect now defines the rectangle we need to update/render the waveview
* into, in window coordinate space. * into, in window coordinate space.
* *
@ -325,7 +330,7 @@ WaveView::get_item_and_draw_rect_in_window_coords (Rect const& canvas_rect, Rect
* and/or end. * and/or end.
*/ */
draw_rect.x0 = floor (draw_rect.x0); draw_rect.x0 = floor (draw_rect.x0);
draw_rect.x1 = floor (draw_rect.x1); draw_rect.x1 = ceil (draw_rect.x1);
return true; return true;
} }