ardour/livetrax
13
0
Fork 0
Code

Fix record/import of note ons with velocity 0.

Browse Source 
Best to just do this as early as possible to avoid having to deal with this
situation all over the code.

Also fixes violation of LV2 MIDI specification, which requires no such events
are delivered to plugins.
This commit is contained in:
David Robillard 2015-02-19 16:54:21 -05:00
parent 6fb4bd578e
commit 450291adfc
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/ardour/midi_port.cc
View File

@ -117,6 +117,10 @@ MidiPort::get_midi_buffer (pframes_t nframes)
if (buf[0] == 0xfe) {
/* throw away active sensing */
continue;
} if (buf[0] == 0x90 && buf[2] == 0) {
/* normalize note on with velocity 0 to proper note off */
buf[0] = 0x80; /* note off */
buf[2] = 0x40; /* default velocity */
}
/* check that the event is in the acceptable time range */

5
libs/evoral/src/SMF.cpp
View File

@ -287,6 +287,11 @@ SMF::read_event(uint32_t* delta_t, uint32_t* size, uint8_t** buf, event_id_t* no
}
memcpy(*buf, event->midi_buffer, size_t(event_size));
*size = event_size;
if ((*buf)[0] == 0x90 && (*buf)[2] == 0) {
/* normalize note on with velocity 0 to proper note off */
(*buf)[0] = 0x80; /* note off */
(*buf)[2] = 0x40; /* default velocity */
}
if (!midi_event_is_valid(*buf, *size)) {
cerr << "WARNING: SMF ignoring illegal MIDI event" << endl;