From 4367b51e565e9233a69e86a47ab48c0027091426 Mon Sep 17 00:00:00 2001 From: Tim Mayberry Date: Wed, 21 Sep 2016 16:23:34 +1000 Subject: [PATCH] Remove PBD::to_string() function from pbd/convert.h All uses of this function have now been replaced by PBD::to_string() from pbd/string_convert.h Remove this function so that it isn't mistakenly used to perform numeric to string conversion when the result is being used for serialization as that only works if the global C++ locale is set with LC_NUMERIC=C, which is the case currently but may not be in the future. --- libs/pbd/pbd/convert.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libs/pbd/pbd/convert.h b/libs/pbd/pbd/convert.h index af40446a81..5adabe684d 100644 --- a/libs/pbd/pbd/convert.h +++ b/libs/pbd/pbd/convert.h @@ -23,8 +23,7 @@ #include #include #include -#include -#include + #include #include "pbd/libpbd_visibility.h" @@ -49,14 +48,6 @@ LIBPBD_API std::string length2string (const int64_t frames, const double sample_ LIBPBD_API std::vector internationalize (const char *, const char **); LIBPBD_API bool strings_equal_ignore_case (const std::string& a, const std::string& b); -template std::string /*LIBPBD_API*/ -to_string (T t, std::ios_base & (*f)(std::ios_base&)) -{ - std::ostringstream oss; - oss << f << t; - return oss.str(); -} - LIBPBD_API const char* sgettext (const char *, const char *); } //namespace PBD