From 4339e3c729310b9afdb34c2d31703df132842056 Mon Sep 17 00:00:00 2001 From: Ben Loftis Date: Sat, 14 May 2022 14:47:54 -0500 Subject: [PATCH] temporarily remove effective_ripple_mark_start behavior citations are needed to explain when&how this is useful the definition of Ripple is "accommodate cut/insert/moves by moving all regions to the 'right' (later) of the operation by the same amount". moving markers to the 'left' of the grabbed_region explicitly breaks the definition of ripple. it makes documentation hard. furthermore, in a more complicated session with multiple tracks, this behavior ignores the regions on other tracks and the markers that still might be associated with them (consider the case where you move the first region on track A but there are many prior regions on track B with markers over them) --- gtk2_ardour/editor_ops.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk2_ardour/editor_ops.cc b/gtk2_ardour/editor_ops.cc index 0c5f8858d8..4f922a99cf 100644 --- a/gtk2_ardour/editor_ops.cc +++ b/gtk2_ardour/editor_ops.cc @@ -9497,6 +9497,7 @@ Editor::do_ripple (boost::shared_ptr target_playlist, timepos_t const timepos_t Editor::effective_ripple_mark_start (boost::shared_ptr target_playlist, timepos_t pos) { +#if 0 /* I do not agree with this behavior - at the very least it ignores regions on *other* tracks and the markers that might be associated with them -Ben */ /* in the target playlist, find the region before the target * (implicitly given by @param at. Allow all markers that occur between * the end of the region and @param at to move too. This is @@ -9516,6 +9517,7 @@ Editor::effective_ripple_mark_start (boost::shared_ptr target_playlist if (last_region_end_before_at < pos) { pos = last_region_end_before_at.increment(); } +#endif return pos; }