ardour/livetrax
13
0
Fork 0
Code

Don't copy-construct MusicFrame, pass const reference.

Browse Source
This commit is contained in:
Robin Gareus 2017-02-15 14:20:26 +01:00
parent d9c7a2ad49
commit 41c432ed3b
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/ardour/ardour/midi_playlist.h
View File

@ -87,7 +87,7 @@ public:
int set_state (const XMLNode&, int version);
bool destroy_region (boost::shared_ptr<Region>);
void _split_region (boost::shared_ptr<Region>, MusicFrame position);
void _split_region (boost::shared_ptr<Region>, const MusicFrame& position);
void set_note_mode (NoteMode m) { _note_mode = m; }

6
libs/ardour/ardour/playlist.h
View File

@ -141,8 +141,8 @@ public:
void get_region_list_equivalent_regions (boost::shared_ptr<Region>, std::vector<boost::shared_ptr<Region> >&);
void get_source_equivalent_regions (boost::shared_ptr<Region>, std::vector<boost::shared_ptr<Region> >&);
void replace_region (boost::shared_ptr<Region> old, boost::shared_ptr<Region> newr, framepos_t pos);
void split_region (boost::shared_ptr<Region>, MusicFrame position);
void split (MusicFrame at);
void split_region (boost::shared_ptr<Region>, const MusicFrame& position);
void split (const MusicFrame& at);
void shift (framepos_t at, frameoffset_t distance, bool move_intersected, bool ignore_music_glue);
void partition (framepos_t start, framepos_t end, bool cut = false);
void duplicate (boost::shared_ptr<Region>, framepos_t position, float times);
@ -390,7 +390,7 @@ public:
void begin_undo ();
void end_undo ();
virtual void _split_region (boost::shared_ptr<Region>, MusicFrame position);
virtual void _split_region (boost::shared_ptr<Region>, const MusicFrame& position);
typedef std::pair<boost::shared_ptr<Region>, boost::shared_ptr<Region> > TwoRegions;

2
libs/ardour/midi_playlist.cc
View File

@ -384,7 +384,7 @@ MidiPlaylist::destroy_region (boost::shared_ptr<Region> region)
return changed;
}
void
MidiPlaylist::_split_region (boost::shared_ptr<Region> region, MusicFrame playlist_position)
MidiPlaylist::_split_region (boost::shared_ptr<Region> region, const MusicFrame& playlist_position)
{
if (!region->covers (playlist_position.frame)) {
return;

6
libs/ardour/playlist.cc
View File

@ -1413,7 +1413,7 @@ Playlist::duplicate_ranges (std::list<AudioRange>& ranges, float times)
}
void
Playlist::split (MusicFrame at)
Playlist::split (const MusicFrame& at)
{
RegionWriteLock rlock (this);
RegionList copy (regions.rlist());
@ -1427,14 +1427,14 @@ Playlist::duplicate_ranges (std::list<AudioRange>& ranges, float times)
}
void
Playlist::split_region (boost::shared_ptr<Region> region, MusicFrame playlist_position)
Playlist::split_region (boost::shared_ptr<Region> region, const MusicFrame& playlist_position)
{
RegionWriteLock rl (this);
_split_region (region, playlist_position);
}
void
Playlist::_split_region (boost::shared_ptr<Region> region, MusicFrame playlist_position)
Playlist::_split_region (boost::shared_ptr<Region> region, const MusicFrame& playlist_position)
{
if (!region->covers (playlist_position.frame)) {
return;