ardour/livetrax
13
0
Fork 0
Code

VST3: work around plugins with missing controller state

Browse Source 
If a plugin implements Vst::IComponent::set_state() but
does not implement Vst::IEditController::setComponentState()
nor dedicated get/setState interface for the IEditController,
querying the parameters using Vst::IEditController::getParamNormalized()
returns values that do reflect the restored state.

In this case the host needs to save/restore all control-parameters,
and ignore values reported by ::getParamNormalized().

This fixes a state save/restore issue with softube.vst3, however
vstpresets are still broken: the GUI (IComponent) is updated,
however the controller isn't.
This commit is contained in:
Robin Gareus 2021-03-02 03:21:08 +01:00
parent 650f027a9b
commit 3722b8a94f
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libs/ardour/vst3_plugin.cc
View File

@ -1754,10 +1754,10 @@ VST3PI::synchronize_states ()
std::cerr << "Failed to synchronize VST3 component <> controller state\n";
stream.hexdump (0);
#endif
return false;
}
return res == kResultOk;
}
return true;
return false;
}
void
@ -2259,6 +2259,7 @@ VST3PI::load_state (RAMStream& stream)
}
bool rv = true;
bool synced = false;
/* parse chunks */
for (ChunkEntryVector::const_iterator i = entries.begin (); i != entries.end (); ++i) {
@ -2274,6 +2275,10 @@ VST3PI::load_state (RAMStream& stream)
s.rewind ();
tresult re2 = _controller->setComponentState (&s);
if (re2 == kResultOk) {
synced = true;
}
if (!(re2 == kResultOk || re2 == kNotImplemented || res == kResultOk || res == kNotImplemented)) {
DEBUG_TRACE (DEBUG::VST3Config, "VST3PI::load_state: failed to restore component state\n");
rv = false;
@ -2281,6 +2286,10 @@ VST3PI::load_state (RAMStream& stream)
} else if (is_equal_ID (i->_id, Vst::getChunkID (Vst::kControllerState))) {
stream.seek (i->_offset, IBStream::kIBSeekSet, &seek_result);
tresult res = _controller->setState (&stream);
if (res == kResultOk) {
synced = true;
}
if (!(res == kResultOk || res == kNotImplemented)) {
DEBUG_TRACE (DEBUG::VST3Config, "VST3PI::load_state: failed to restore controller state\n");
rv = false;
@ -2302,8 +2311,11 @@ VST3PI::load_state (RAMStream& stream)
DEBUG_TRACE (DEBUG::VST3Config, "VST3PI::load_state: ignored unsupported state chunk.\n");
}
}
if (rv && !synced) {
synced = synchronize_states ();
}
if (rv) {
if (rv && synced) {
update_shadow_data ();
}
return rv;