ardour/livetrax
13
0
Fork 0
Code

Fix Ardour VAMP plugins (FFT)

Browse Source 
Bug was introduced in 8ed33f1bc7 symbol visibility setting
in CFLAGS, CXXFLAGS was overridden. This resulted in publicly exposed
and bound kiss_fft symbols in libqm-dsp.

At runtime those symbols were resolved using previously bound
symbols in libcodec  (see below) that uses a mismatching implementation
(ardour/qm-dsp uses -Dkiss_fft_scalar=double)

#0  0x00007fffea793d40 in kiss_fftr () at /usr/lib/x86_64-linux-gnu/libcodec2.so.0.8.1
#1  0x00007fffcf4516ab in FFTReal::D::forward(double const*, double*, double*) (this=0x5555571d73a0, ri=0x55555a734810, ro=0x55555a7262b0, io=0x55555a728590)
    at ../libs/qm-dsp/dsp/transforms/FFT.cpp:121
#2  0x00007fffcf4510fd in FFTReal::forward(double const*, double*, double*) (this=0x555559868190, ri=0x55555a734810, ro=0x55555a7262b0, io=0x55555a728590)
    at ../libs/qm-dsp/dsp/transforms/FFT.cpp:186
This commit is contained in:
Robin Gareus 2020-01-14 00:43:34 +01:00
parent 2c9b301912
commit 34c4f7b8ee
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/qm-dsp/wscript
View File

@ -79,8 +79,8 @@ def build(bld):
obj.vnum = QM_DSP_VERSION obj.vnum = QM_DSP_VERSION
obj.install_path = bld.env['LIBDIR'] obj.install_path = bld.env['LIBDIR']
if bld.env['build_target'] != 'mingw': if bld.env['build_target'] != 'mingw':
obj.cxxflags = [ bld.env['compiler_flags_dict']['pic'] ] obj.cxxflags += [ bld.env['compiler_flags_dict']['pic'] ]
obj.cflags = [ bld.env['compiler_flags_dict']['pic'] ] obj.cflags += [ bld.env['compiler_flags_dict']['pic'] ]
def shutdown(): def shutdown():