From 31de7e93bf2f7b64af8c078aad67f7f85005b21b Mon Sep 17 00:00:00 2001
From: Paul Davis <paul@linuxaudiosystems.com>
Date: Thu, 22 Jun 2023 12:30:22 -0600
Subject: [PATCH] lollis: show note selected status (using note selection
 outlien color)

---
 gtk2_ardour/ghostregion.h            |  1 +
 gtk2_ardour/midi_region_view.cc      | 25 ++++++++++++++++++++++---
 gtk2_ardour/midi_region_view.h       |  2 ++
 gtk2_ardour/velocity_ghost_region.cc | 14 ++++++++++++++
 gtk2_ardour/velocity_ghost_region.h  |  1 +
 5 files changed, 40 insertions(+), 3 deletions(-)

diff --git a/gtk2_ardour/ghostregion.h b/gtk2_ardour/ghostregion.h
index 701bbdf160..8a682f3e75 100644
--- a/gtk2_ardour/ghostregion.h
+++ b/gtk2_ardour/ghostregion.h
@@ -126,6 +126,7 @@ public:
 	virtual void update_note (GhostEvent* note);
 	virtual void update_hit (GhostEvent* hit);
 	virtual void remove_note (NoteBase*);
+	virtual void note_selected (NoteBase*) {}
 
 	void model_changed();
 	void view_changed();
diff --git a/gtk2_ardour/midi_region_view.cc b/gtk2_ardour/midi_region_view.cc
index 7822179aa4..7c623b2481 100644
--- a/gtk2_ardour/midi_region_view.cc
+++ b/gtk2_ardour/midi_region_view.cc
@@ -2245,9 +2245,10 @@ MidiRegionView::clear_selection_internal ()
 {
 	DEBUG_TRACE(DEBUG::Selection, "MRV::clear_selection_internal\n");
 
-	for (Selection::iterator i = _selection.begin(); i != _selection.end(); ++i) {
-		(*i)->set_selected(false);
-		(*i)->hide_velocity();
+	for (auto & sel : _selection) {
+		sel->set_selected(false);
+		sel->hide_velocity();
+		sync_ghost_selection (sel);
 	}
 	_selection.clear();
 }
@@ -2586,6 +2587,8 @@ MidiRegionView::remove_from_selection (NoteBase* ev)
 	ev->set_selected (false);
 	ev->hide_velocity ();
 
+	sync_ghost_selection (ev);
+
 	if (_selection.empty()) {
 		PublicEditor& editor (trackview.editor());
 		editor.get_selection().remove (this);
@@ -2629,6 +2632,20 @@ MidiRegionView::add_to_selection (NoteBase* ev)
 	if (_selection.insert (ev).second == true) {
 		ev->set_selected (true);
 		start_playing_midi_note ((ev)->note());
+		sync_ghost_selection (ev);
+	}
+}
+
+void
+MidiRegionView::sync_ghost_selection (NoteBase* ev)
+{
+	for (auto & ghost : ghosts) {
+
+		MidiGhostRegion* gr;
+
+		if ((gr = dynamic_cast<MidiGhostRegion*>(ghost)) != 0) {
+			gr->note_selected (ev);
+		}
 	}
 }
 
@@ -4232,6 +4249,7 @@ MidiRegionView::maybe_select_by_position (GdkEventButton* ev, double /*x*/, doub
 	for (Events::iterator i = e.begin(); i != e.end(); ++i) {
 		if (_selection.insert (i->second).second) {
 			i->second->set_selected (true);
+			sync_ghost_selection (i->second);
 		}
 	}
 
@@ -4251,6 +4269,7 @@ MidiRegionView::color_handler ()
 
 	for (Events::iterator i = _events.begin(); i != _events.end(); ++i) {
 		i->second->set_selected (i->second->selected()); // will change color
+		sync_ghost_selection (i->second);
 	}
 
 	/* XXX probably more to do here */
diff --git a/gtk2_ardour/midi_region_view.h b/gtk2_ardour/midi_region_view.h
index be224d65ad..209924e6d3 100644
--- a/gtk2_ardour/midi_region_view.h
+++ b/gtk2_ardour/midi_region_view.h
@@ -580,6 +580,8 @@ public:
 	void update_sysexes ();
 	void view_changed ();
 	void model_changed ();
+
+	void sync_ghost_selection (NoteBase*);
 };
 
 
diff --git a/gtk2_ardour/velocity_ghost_region.cc b/gtk2_ardour/velocity_ghost_region.cc
index 513198bbcb..d9b3f26a8b 100644
--- a/gtk2_ardour/velocity_ghost_region.cc
+++ b/gtk2_ardour/velocity_ghost_region.cc
@@ -226,3 +226,17 @@ VelocityGhostRegion::y_position_to_velocity (double y) const
 
 	return velocity;
 }
+
+void
+VelocityGhostRegion::note_selected (NoteBase* ev)
+{
+	GhostEvent* gev = find_event (ev->note());
+
+	if (!gev) {
+		return;
+	}
+
+	ArdourCanvas::Lollipop* lolli = dynamic_cast<ArdourCanvas::Lollipop*> (gev->item);
+	lolli->set_outline_color (ev->selected() ? UIConfiguration::instance().color ("midi note selected outline") : 0x000000ff);
+}
+
diff --git a/gtk2_ardour/velocity_ghost_region.h b/gtk2_ardour/velocity_ghost_region.h
index 9b65f5df09..3ad1e9f9fe 100644
--- a/gtk2_ardour/velocity_ghost_region.h
+++ b/gtk2_ardour/velocity_ghost_region.h
@@ -38,6 +38,7 @@ public:
 	void update_note (GhostEvent* note);
 	void update_hit (GhostEvent* hit);
 	void remove_note (NoteBase*);
+	void note_selected (NoteBase*);
 
 	void set_colors ();
 	void drag_lolli (ArdourCanvas::Lollipop* l, GdkEventMotion* ev);