From 2d076cccb1286b0ea662009d9147dc06592ba643 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 30 Aug 2024 02:18:49 +0200 Subject: [PATCH] Only enable RegionFX in debug builds for the time being --- gtk2_ardour/audio_region_editor.cc | 2 ++ gtk2_ardour/region_editor.cc | 4 ++++ libs/ardour/luabindings.cc | 2 ++ 3 files changed, 8 insertions(+) diff --git a/gtk2_ardour/audio_region_editor.cc b/gtk2_ardour/audio_region_editor.cc index c1aea81769..e76c086fdf 100644 --- a/gtk2_ardour/audio_region_editor.cc +++ b/gtk2_ardour/audio_region_editor.cc @@ -98,6 +98,7 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv) _table.attach (_pre_fade_fx_toggle, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL); ++_table_row; +#ifndef NDEBUG // disable region Fx for now _region_line_label.set_name ("AudioRegionEditorLabel"); _region_line_label.set_text (_("Region Line:")); _region_line_label.set_alignment (1, 0.5); @@ -105,6 +106,7 @@ AudioRegionEditor::AudioRegionEditor (Session* s, AudioRegionView* arv) _table.attach (_region_line, 1, 2, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL); _table.attach (_show_on_touch, 2, 3, _table_row, _table_row + 1, Gtk::FILL, Gtk::FILL); ++_table_row; +#endif UI::instance()->set_tip (_polarity_toggle, _("Invert the signal polarity (180deg phase shift)")); UI::instance()->set_tip (_pre_fade_fx_toggle, _("Apply region effects before the region fades.\nThis is useful if the effect(s) have tail, that would otherwise be faded out by the region fade (e.g. reverb, delay)")); diff --git a/gtk2_ardour/region_editor.cc b/gtk2_ardour/region_editor.cc index 44a832dcd2..650dd1c73b 100644 --- a/gtk2_ardour/region_editor.cc +++ b/gtk2_ardour/region_editor.cc @@ -187,8 +187,10 @@ RegionEditor::RegionEditor (Session* s, RegionView* rv) _table.attach (_sources, 1, 2, _table_row, _table_row + 1, Gtk::FILL | Gtk::EXPAND, Gtk::FILL); ++_table_row; +#ifndef NDEBUG // disable region FX for now _table.attach (region_fx_label, 2, 3, 0, 1, Gtk::FILL, Gtk::FILL); _table.attach (_region_fx_box, 2, 3, 1, _table_row + 2, Gtk::FILL, Gtk::FILL); +#endif get_vbox()->pack_start (_table, true, true); @@ -230,11 +232,13 @@ RegionEditor::RegionEditor (Session* s, RegionView* rv) spin_arrow_grab = false; +#ifndef NDEBUG // disable region FX for now /* for now only audio region effects are supported */ if (std::dynamic_pointer_cast (_region)) { region_fx_label.show (); _region_fx_box.show (); } +#endif connect_editor_events (); } diff --git a/libs/ardour/luabindings.cc b/libs/ardour/luabindings.cc index c0e558c763..9e96eb46aa 100644 --- a/libs/ardour/luabindings.cc +++ b/libs/ardour/luabindings.cc @@ -1638,10 +1638,12 @@ LuaBindings::common (lua_State* L) .addFunction ("has_transients", &Region::has_transients) .addFunction ("transients", (AnalysisFeatureList (Region::*)())&Region::transients) +#ifndef NDEBUG // disable region FX for now .addFunction ("load_plugin", &Region::load_plugin) .addFunction ("add_plugin", &Region::add_plugin) .addFunction ("remove_plugin", &Region::add_plugin) .addFunction ("nth_plugin", &Region::nth_plugin) +#endif /* editing operations */ .addFunction ("set_length", &Region::set_length)