From 28605b53515b3d1bd8da5c1eada8946d1dffa79c Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Sat, 28 Sep 2024 21:06:55 +0200 Subject: [PATCH] Fix Audio region fade property mapping This fixes an issue when undoing region fades. Particularly but not limited to the following: 1. select a region and split it in the middle 2. switch to range tool. make a range selection across the split 3. Edit > Fade > Fade range seection (or press `/`) 4. Undo Previously the fade-out of the earlier region was not undone. --- libs/ardour/audioregion.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libs/ardour/audioregion.cc b/libs/ardour/audioregion.cc index e813642d41..0b937f26a7 100644 --- a/libs/ardour/audioregion.cc +++ b/libs/ardour/audioregion.cc @@ -234,9 +234,9 @@ AudioRegion::register_properties () , _fade_before_fx (Properties::fade_before_fx, other->_fade_before_fx) \ , _scale_amplitude (Properties::scale_amplitude, other->_scale_amplitude) \ , _fade_in (Properties::fade_in, std::shared_ptr (new AutomationList (*other->_fade_in.val()))) \ - , _inverse_fade_in (Properties::fade_in, std::shared_ptr (new AutomationList (*other->_inverse_fade_in.val()))) \ - , _fade_out (Properties::fade_in, std::shared_ptr (new AutomationList (*other->_fade_out.val()))) \ - , _inverse_fade_out (Properties::fade_in, std::shared_ptr (new AutomationList (*other->_inverse_fade_out.val()))) + , _inverse_fade_in (Properties::inverse_fade_in, std::shared_ptr (new AutomationList (*other->_inverse_fade_in.val()))) \ + , _fade_out (Properties::fade_out, std::shared_ptr (new AutomationList (*other->_fade_out.val()))) \ + , _inverse_fade_out (Properties::inverse_fade_out, std::shared_ptr (new AutomationList (*other->_inverse_fade_out.val()))) /* a Session will reset these to its chosen defaults by calling AudioRegion::set_default_fade() */ void