13
0

no actual error messages when curl requests fail

This commit is contained in:
Paul Davis 2018-05-23 23:08:13 -04:00
parent 07466440c4
commit 1e5813cf18

View File

@ -186,7 +186,6 @@ HttpGet::get (const char* url)
#endif #endif
_status = _result = -1; _status = _result = -1;
if (!_curl || !url) { if (!_curl || !url) {
PBD::error << "HttpGet::get() not initialized (or NULL url)"<< endmsg;
#ifdef ARDOURCURLDEBUG #ifdef ARDOURCURLDEBUG
std::cerr << "HttpGet::get() not initialized (or NULL url)"<< std::endl; std::cerr << "HttpGet::get() not initialized (or NULL url)"<< std::endl;
#endif #endif
@ -194,7 +193,6 @@ HttpGet::get (const char* url)
} }
if (strncmp ("http://", url, 7) && strncmp ("https://", url, 8)) { if (strncmp ("http://", url, 7) && strncmp ("https://", url, 8)) {
PBD::error << "HttpGet::get() not a http[s] URL"<< endmsg;
#ifdef ARDOURCURLDEBUG #ifdef ARDOURCURLDEBUG
std::cerr << "HttpGet::get() not a http[s] URL"<< std::endl; std::cerr << "HttpGet::get() not a http[s] URL"<< std::endl;
#endif #endif
@ -218,14 +216,12 @@ HttpGet::get (const char* url)
CCERR ("CURLINFO_RESPONSE_CODE,"); CCERR ("CURLINFO_RESPONSE_CODE,");
if (_result) { if (_result) {
PBD::error << string_compose (_("HTTP request failed: (%1) %2"), _result, error_buffer) << endmsg;
#ifdef ARDOURCURLDEBUG #ifdef ARDOURCURLDEBUG
std::cerr << string_compose (_("HTTP request failed: (%1) %2"), _result, error_buffer) << std::endl; std::cerr << string_compose (_("HTTP request failed: (%1) %2"), _result, error_buffer) << std::endl;
#endif #endif
return NULL; return NULL;
} }
if (_status != 200) { if (_status != 200) {
PBD::error << string_compose (_("HTTP request status: %1"), _status) << endmsg;
#ifdef ARDOURCURLDEBUG #ifdef ARDOURCURLDEBUG
std::cerr << string_compose (_("HTTP request status: %1"), _status) << std::endl; std::cerr << string_compose (_("HTTP request status: %1"), _status) << std::endl;
#endif #endif