Make boolean string values 0 and 1 to maintain backwards compatibility
I would prefer "yes" and "no" as it distinguishes boolean values from numeric but using "yes and "no" results in PBD::Property<T>::from_string failing to parse the correct values when opening in an older Ardour version as there is no specialization for bool. Using 0 and 1 also results in less change to the Session file.
This commit is contained in:
parent
362303f793
commit
13bfd1527a
@ -210,9 +210,9 @@ bool string_to_double (const std::string& str, double& val)
|
|||||||
bool bool_to_string (bool val, std::string& str)
|
bool bool_to_string (bool val, std::string& str)
|
||||||
{
|
{
|
||||||
if (val) {
|
if (val) {
|
||||||
str = X_("yes");
|
str = X_("1");
|
||||||
} else {
|
} else {
|
||||||
str = X_("no");
|
str = X_("0");
|
||||||
}
|
}
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
@ -564,8 +564,8 @@ StringConvertTest::test_double_conversion ()
|
|||||||
}
|
}
|
||||||
|
|
||||||
// we have to use these as CPPUNIT_ASSERT_EQUAL won't accept char arrays
|
// we have to use these as CPPUNIT_ASSERT_EQUAL won't accept char arrays
|
||||||
static const std::string BOOL_TRUE_STR ("yes");
|
static const std::string BOOL_TRUE_STR ("1");
|
||||||
static const std::string BOOL_FALSE_STR ("no");
|
static const std::string BOOL_FALSE_STR ("0");
|
||||||
|
|
||||||
void
|
void
|
||||||
StringConvertTest::test_bool_conversion ()
|
StringConvertTest::test_bool_conversion ()
|
||||||
|
Loading…
Reference in New Issue
Block a user