13
0

expand comment to include (more of?) the full story about uncombining and copies

This commit is contained in:
Paul Davis 2020-01-08 22:21:08 -07:00
parent 965bf74f2b
commit 0e42708685

View File

@ -3238,7 +3238,7 @@ Playlist::uncombine (boost::shared_ptr<Region> target)
RegionFactory::CompoundAssociations& cassocs (RegionFactory::compound_associations()); RegionFactory::CompoundAssociations& cassocs (RegionFactory::compound_associations());
sampleoffset_t move_offset = 0; sampleoffset_t move_offset = 0;
/* there are two possibilities here: /* there are three possibilities here:
1) the playlist that the playlist source was based on 1) the playlist that the playlist source was based on
is us, so just add the originals (which belonged to is us, so just add the originals (which belonged to
us anyway) back in the right place. us anyway) back in the right place.
@ -3247,6 +3247,10 @@ Playlist::uncombine (boost::shared_ptr<Region> target)
is NOT us, so we need to make copies of each of is NOT us, so we need to make copies of each of
the original regions that we find, and add them the original regions that we find, and add them
instead. instead.
3) target region is a copy of a compount region previously
created. In this case we will also need to make copies ot each of
the original regions, and add them instead.
*/ */
const bool need_copies = (boost::dynamic_pointer_cast<PlaylistSource> (pls)->owner() != target->id()) || const bool need_copies = (boost::dynamic_pointer_cast<PlaylistSource> (pls)->owner() != target->id()) ||