Don't allow recursive calls to EngineDialog
OK -> start_engine() can eg. trigger an interactive plugin scan, which in turn leaves the EngineDialog responsive. changing settings or clicking OK again can lead to undefined behavior.
This commit is contained in:
parent
97f81479d3
commit
0b8a7d3429
@ -466,10 +466,10 @@ EngineControl::on_response (int response_id)
|
|||||||
|
|
||||||
switch (response_id) {
|
switch (response_id) {
|
||||||
case RESPONSE_OK:
|
case RESPONSE_OK:
|
||||||
|
hide();
|
||||||
if (!start_engine()) {
|
if (!start_engine()) {
|
||||||
|
show();
|
||||||
return;
|
return;
|
||||||
} else {
|
|
||||||
hide();
|
|
||||||
}
|
}
|
||||||
#ifdef PLATFORM_WINDOWS
|
#ifdef PLATFORM_WINDOWS
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user