13
0

Don't allow recursive calls to EngineDialog

OK -> start_engine() can eg. trigger an interactive plugin scan,
which in turn leaves the EngineDialog responsive. changing settings
or clicking OK again can lead to undefined behavior.
This commit is contained in:
Robin Gareus 2016-11-19 04:54:36 +01:00
parent 97f81479d3
commit 0b8a7d3429

View File

@ -466,10 +466,10 @@ EngineControl::on_response (int response_id)
switch (response_id) {
case RESPONSE_OK:
hide();
if (!start_engine()) {
show();
return;
} else {
hide();
}
#ifdef PLATFORM_WINDOWS