ardour/livetrax
13
0
Fork 0
Code

Temporal: mark Beats::operator bool() as explicit, to avoid unintended/accidental use when implicitly casting to int/float types

Browse Source
This commit is contained in:
Paul Davis 2020-12-12 17:21:43 -07:00
parent 5e0cf747bb
commit 05740e7069
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libs/temporal/temporal/beats.h
View File

@ -46,8 +46,7 @@ class MidiModel;
class AutomationList;
class MidiSource;
class MidiRegion;
/* these use ::to_double() but should be removed */
class DoubleBeatsSamplesConverter;
class Quantize;
}
namespace Evoral {
@ -339,7 +338,7 @@ public:
}
bool operator!() const { return _beats == 0 && _ticks == 0; }
operator bool () const { return _beats != 0 || _ticks != 0; }
explicit operator bool () const { return _beats != 0 || _ticks != 0; }
static Beats one_tick() { return Beats(0, 1); }
@ -356,7 +355,7 @@ private:
friend class ARDOUR::AutomationList;
friend class ARDOUR::MidiSource;
friend class ARDOUR::MidiRegion;
friend class ARDOUR::DoubleBeatsSamplesConverter;
friend class ARDOUR::Quantize;
friend class ::QuantizeDialog;
friend class ::NoteDrag;
friend class ::NoteCreateDrag;