when disconnecting a MIDI port for follows-selection, get ALL connections

without the 3rd argument, we only get information about ports that we own.

gtk2_ardour/mixer_strip.cc

@@ -351,6 +351,14 @@ MixerStrip::init ()
 	global_vpacker.pack_start (output_button, Gtk::PACK_SHRINK);
 	global_vpacker.pack_start (_comment_button, Gtk::PACK_SHRINK);
 
+	midi_input_enable_button.set_size_request (PX_SCALE(19), PX_SCALE(19));
+	midi_input_enable_button.set_name ("midi input button");
+	midi_input_enable_button.set_elements ((ArdourButton::Element)(ArdourButton::Edge|ArdourButton::Body|ArdourButton::VectorIcon));
+	midi_input_enable_button.set_icon (ArdourIcon::DinMidi);
+	midi_input_enable_button.signal_button_press_event().connect (sigc::mem_fun (*this, &MixerStrip::input_active_button_press), false);
+	midi_input_enable_button.signal_button_release_event().connect (sigc::mem_fun (*this, &MixerStrip::input_active_button_release), false);
+	set_tooltip (midi_input_enable_button, _("Enable/Disable MIDI input"));
+
 #ifndef MIXBUS
 	//add a spacer underneath the master bus;
 	//this fills the area that is taken up by the scrollbar on the tracks;
@@ -684,15 +692,9 @@ MixerStrip::set_route (std::shared_ptr<Route> rt)
 	update_trim_control();
 
 	if (is_midi_track()) {
-
-		midi_input_enable_button.set_size_request (PX_SCALE(19), PX_SCALE(19));
-		midi_input_enable_button.set_name ("midi input button");
-		midi_input_enable_button.set_elements ((ArdourButton::Element)(ArdourButton::Edge|ArdourButton::Body|ArdourButton::VectorIcon));
-		midi_input_enable_button.set_icon (ArdourIcon::DinMidi);
-		midi_input_enable_button.signal_button_press_event().connect (sigc::mem_fun (*this, &MixerStrip::input_active_button_press), false);
-		midi_input_enable_button.signal_button_release_event().connect (sigc::mem_fun (*this, &MixerStrip::input_active_button_release), false);
-		set_tooltip (midi_input_enable_button, _("Enable/Disable MIDI input"));
-		input_button_box.pack_start (midi_input_enable_button, false, false);
+		if (!midi_input_enable_button.get_parent()) {
+			input_button_box.pack_start (midi_input_enable_button, false, false);
+		}
 
 		/* get current state */
 		midi_input_status_changed ();

libs/ardour/ardour/port_manager.h

@@ -151,7 +151,7 @@ public:
 
 	bool connected (const std::string&);
 	bool physically_connected (const std::string&);
-	int  get_connections (const std::string&, std::vector<std::string>&);
+	int  get_connections (const std::string&, std::vector<std::string>&, bool process_context_safe = true);
 
 	/* Naming */
 

libs/ardour/port_manager.cc

@@ -749,7 +749,7 @@ PortManager::physically_connected (const string& port_name)
 }
 
 int
-PortManager::get_connections (const string& port_name, std::vector<std::string>& s)
+PortManager::get_connections (const string& port_name, std::vector<std::string>& s, bool process_context_safe)
 {
 	if (!_backend) {
 		s.clear ();
@@ -763,7 +763,7 @@ PortManager::get_connections (const string& port_name, std::vector<std::string>&
 		return 0;
 	}
 
-	return _backend->get_connections (handle, s);
+	return _backend->get_connections (handle, s, process_context_safe);
 }
 
 int

libs/ardour/session_midi.cc

@@ -744,7 +744,8 @@ Session::disconnect_port_for_rewire (std::string const& port) const
 	bool keep_ctrl = mpf & MidiPortControl;
 
 	vector<string> port_connections;
-	AudioEngine::instance()->get_connections (port, port_connections);
+	AudioEngine::instance()->get_connections (port, port_connections, false);
+
 	for (vector<string>::iterator i = port_connections.begin(); i != port_connections.end(); ++i) {
 
 		/* test if (*i) is a control-surface input port */