Commit Graph

156 Commits

Author SHA1 Message Date
9283e97435 refine add preset/favorite dialog
dedicated "Add to Favorites only" mode.
2015-12-28 17:23:45 +01:00
ac008dac02 Clean up generic and LV2 plugin GUI to deal with ParameterChanged(Externally) alteration 2015-10-20 10:23:49 -04:00
7804a524dc Revert "rename ParameterChanged signal in Plugin to ParameterChangedExternally to reflect its intent, and clean up the result."
This reverts commit 336b2eb9a4.
2015-10-20 10:23:49 -04:00
336b2eb9a4 rename ParameterChanged signal in Plugin to ParameterChangedExternally to reflect its intent, and clean up the result.
The signal exists to notify listeners that something outside of the host's control (e.g. a plugin's own GUI for AU or VST)
has modified a plugin parameter. Previous code had strange feedback loops and ambiguous semantics.

Significant modification of LV2 GUI updating was required.

Still to be tested for feedback loop issues: AudioUnits
2015-10-20 09:07:58 -04:00
22b07e0233 NOOP, remove trailing tabs/whitespace. 2015-10-05 16:17:49 +02:00
4dc63966f0 globally remove all trailing whitespace from ardour code base.
Paul Davis was responsible for introducing almost all of this.
2015-10-04 14:51:05 -04:00
1d42ed077e Use ARDOUR_UI_UTILS::set_tooltip rather than via ARDOUR_UI::set_tip
This removes the direct dependence on ARDOUR_UI/Gtk_UI for setting
tooltips. Removes inclusion of ardour_ui.h from 16 files.
2015-09-16 16:55:17 -04:00
9790d2b5dd prepare plugin reset (#6297) 2015-05-04 20:48:41 +02:00
60589268e8 fix another untranslatable 2015-04-03 03:26:21 +02:00
4f0457264e revert plugin UI kbd handling so that we get expected forwarding 2015-04-01 16:54:09 -04:00
1b1c66b77d reverse logic in plugin GUI key handling 2015-04-01 14:13:14 -04:00
nick_m
35f69656e8 Window focus handling fixes.
Many windows were not getting key events.
Use magic focus infrastructure (built for widgets) to deliver key events
via window focus in/out.
2015-04-02 02:41:49 +11:00
91405a1b2f consolidate plugin freebie messages, fix #6151 2015-03-23 00:05:47 +01:00
0cb096a978 Use Ardour widgets consistently in plugin UI.
Several reasons:

* This previously looked horribly inconsistent.

* The Gtk selector was broken for plugins with many presets,
  making it impossible to select presets.  For whatever reason,
  the use of a menu fixes this bug.

* Towards a hierarchical menu for banked presets.
2015-03-07 14:04:45 -05:00
a0eeb80885 fix embedded plugin UI keyboard handling
When the GUI is opened the first time all is fine, focus is on the
embedded widget. However once a user presses one of the preset buttons
(Add, Save,...) there is no possibility to return focus to the
embedded widget. Ardour always 'sees' it as focus=GtkButton and passes
the event to the editor.
2015-02-21 03:16:04 +01:00
642e4950b9 hook up focus_button for LV2 GUIs 2015-02-21 03:00:33 +01:00
b0477f7f1e fix plugin bypass button action 2014-08-28 15:29:18 -05:00
a3c378cf62 move utility functions into a dedicated namespace 2014-06-25 21:47:54 +02:00
06b700abf2 fix VST GUI swallowing for windows 2014-04-18 01:54:59 +02:00
2b9421fd39 merge (w/fix) with master 2014-02-04 14:21:35 -05:00
4818621a27 fix typo ndef, NDEBUG 2014-02-03 20:25:05 +01:00
57f59025d7 don't display debug message in no-debug builds 2014-02-03 17:00:03 +01:00
e466ce40ad Merge branch 'master' into windows+cc
Conflicts (hopefully resolved):
	gtk2_ardour/ardour_ui.cc
2013-10-14 19:31:22 +01:00
a244075fb3 changes that will help fix a crash related to plugin window visibility. some work still to be done 2013-10-14 09:54:38 -04:00
a90858897e do not use delete_when_idle() to delete a plugin UI because an entirely separate mechanism exists for that 2013-10-12 16:44:50 -04:00
bb826f4bee incomplete merge of master into windows (requires upcoming changes to master to be complete) 2013-09-12 11:28:50 -04:00
1ab61b8564 major redesign of MIDI port heirarchy and management (part 2) 2013-08-07 22:22:11 -04:00
742753a996 Don't require liblrdf on windows
This removes dependence on liblrdf, libraptor and libxslt
2013-07-11 14:20:02 -04:00
07be5beee7 window delete/hide is managed by WMProxy (amend to cb6f16ac) 2013-07-07 22:29:45 +02:00
80a13145f3 Generalize no-plugin-state from AudioUnits to all plugins
Replace AU_STATE_SUPPORT compile-time define with NO_PLUGIN_STATE and make it prevent plugin state setting, preset loading, preset saving and plugin state saving. Blocks on these actions exist partially in the backend and partially in the GUI (this latter class are not absolute, and should OSC or MIDI be able to drive Plugin::save_preset() the block could be circumvented). Set NO_PLUGIN_STATE if --freebie is used at waf-configure time
2013-06-13 22:50:54 -04:00
00f94a04cc remove unused virtual event handlers from PluginUIWindow 2013-05-02 21:12:59 -04:00
3973ce81b3 remove all of Gtk::Window::set_position (WIN_POS_MOUSE) for anything deriving from ArdourDialog or ArdourWindow; move the set_position() call into those classes' constructors, so that they are called before the windows are realized, and thus it actually works 2013-05-02 18:13:35 -04:00
7df1654947 make PluginUIWindow inherit from ArdourWindow not GtkWindow 2013-05-02 10:11:57 -04:00
d54a35a671 cleanup AU GUI support, which was broken because prefheight and prefwidth were left unset after a cleanup attempt some months ago. add a few more tweaks based on current 2.x code and some tricks found elsewhere that dont' change behaviour but are just better 2013-04-30 11:15:23 -04:00
241a9edd3e replace final(?) incidences of program name (ardour, Ardour) with PROGRAM_NAME (thanks to edgar for tracking them all down)
git-svn-id: svn://localhost/ardour2/branches/3.0@14050 d708f5d6-7413-0410-9779-e7cbd77b26cf
2013-02-05 18:18:35 +00:00
6f7b319d14 another plural fix from Mr Prokoudine.
git-svn-id: svn://localhost/ardour2/branches/3.0@13783 d708f5d6-7413-0410-9779-e7cbd77b26cf
2013-01-05 12:30:12 +00:00
5932b7903a fix compiler warning
git-svn-id: svn://localhost/ardour2/branches/3.0@13526 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-11-18 15:35:02 +00:00
95bd893d5e Disable vulgar keep-above for plugin UIs.
I vaguely recall it being mentioned that this was a kludge for OSX.  Maybe not and somebody will complain.  Oh well, this behaviour is incredibly obnoxious in some environments, and makes plugins that open dialogs (e.g. open file dialogs) completely unusable, and just generally wrong and evil.  I have to try.

git-svn-id: svn://localhost/ardour2/branches/3.0@13521 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-11-18 04:23:45 +00:00
46d785e720 keep latency dialog for plugins above the plugin GUI
git-svn-id: svn://localhost/ardour2/branches/3.0@12820 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-06-22 16:38:15 +00:00
774e55bcc0 sshhh
git-svn-id: svn://localhost/ardour2/branches/3.0@12815 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-06-21 21:02:38 +00:00
1df227424a patch from colinf that adds an 'empty' preset to the preset drop-down list, so that plugins can be set back to the 'no preset' state rather than being stuck in the state of 'preset loaded and modified'. This should apply to all plugin types, though I've only tried it on LV2 and LADSPA.
git-svn-id: svn://localhost/ardour2/branches/3.0@12787 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-06-19 16:02:24 +00:00
e5bb4c94ed kludgy hack/fix for plugin windows reappearing at (0,0) after re-activating ardour as app on OS X. having spent an entire day investigating the issue, this seems like an expedient though sad fix
git-svn-id: svn://localhost/ardour2/branches/3.0@12573 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-06-06 01:43:35 +00:00
674a7b3ac0 no need for an explicit disconnect
git-svn-id: svn://localhost/ardour2/branches/3.0@12300 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-05-16 00:15:46 +00:00
ffe5a6c5c2 Add "Description" pane to generic plugin UI for LV2 plugins with documentation (rdfs:comment property).
A Gtk::Entry might be better here, making Gtk::Label wrap based on size is tedious...


git-svn-id: svn://localhost/ardour2/branches/3.0@12043 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-04-20 02:12:29 +00:00
1716dc0ce6 Update to latest LV2 atom extension.
Implement proper support for fixed size LV2 plugin UIs.


git-svn-id: svn://localhost/ardour2/branches/3.0@11757 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-03-25 17:17:40 +00:00
b08d13706f remove additional "mid" color from ArdourButton; replace Active/Mid widget state with ExplicitActive/ImplicitActive; represent implicit-active state with colored border around ArdourButton; tune button colors; new rounded_foo() functions, some in use, some not in use right now
git-svn-id: svn://localhost/ardour2/branches/3.0@11466 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-02-07 17:43:55 +00:00
d2428e8510 patch from colinf to fix the width of generic plugin editors
git-svn-id: svn://localhost/ardour2/branches/3.0@11401 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-01-31 20:48:47 +00:00
07b4626ea5 build changes from robin gareus for OS X, changing AU support to be used appropriately rather than GTKOSX
git-svn-id: svn://localhost/ardour2/branches/3.0@10869 d708f5d6-7413-0410-9779-e7cbd77b26cf
2011-12-02 20:03:03 +00:00
Carl Hetherington
e6535b3c34 Fix warning.
git-svn-id: svn://localhost/ardour2/branches/3.0@10802 d708f5d6-7413-0410-9779-e7cbd77b26cf
2011-11-23 19:29:43 +00:00
Carl Hetherington
013b31f1bb Don't fix size of preset combo any more. Comment what
widgets the PlugUIBase makes available for subclasses. 
Give up on trying to report when a VST plugin's settings
have been modified from a preset, since I think it is
impossible to do cleanly (you set the preset, then at some
point after that the plugin tells you that values have
changed using the same mechanism that it uses to report
normal user-initiated changes).


git-svn-id: svn://localhost/ardour2/branches/3.0@10798 d708f5d6-7413-0410-9779-e7cbd77b26cf
2011-11-23 17:48:10 +00:00