Commit Graph

332 Commits

Author SHA1 Message Date
Ben Loftis a899136cae Fix egregious playlist copy+paste thinko
* when you copy a Range into a playlist, the playlist's 'timeline' should
 begin at the start of the selected Range.  Regions should retain the
 offset they had from the Range's start.
2022-05-13 12:05:04 -05:00
luz paz 1e640563d6
Fix source comment typos in `libs/ardour`
Found via `codespell`
2022-05-11 00:14:28 +02:00
Paul Davis 7bf89ce109 Constification: make Stateful::get_state() const, with all other required const-ness added (libs) 2022-04-06 21:56:59 -06:00
Paul Davis c0eb86b586 hide debug iteration inside #ifdef 2022-04-05 20:52:10 -06:00
Robin Gareus d841b13673
Fix moving automation with region
This issue was introduced in
eae9d276fe
by using the incorrect new nutempo methods for the case at hand.
2022-03-28 19:39:45 +02:00
Paul Davis 54367e5aef playlist: use C++11 style iterators wherever possible 2022-03-14 14:52:46 -06:00
Robin Gareus 1462590ace
Fix setting session-range when regions move
Since cc6c0f1263 there is no Properties::position event
when a region is moved. So notify_region_moved() or
notify_region_start_trimmed() was never emitted and
Session::maybe_update_session_range() was not called.
2022-03-04 22:37:28 +01:00
Paul Davis 866ba8b174 playlist: find_prev_region_start() should return zero if no earlier region is found (used during rippling 2022-01-30 22:49:52 -07:00
Robin Gareus 60be0c27a1
Use updated temporal API 1/2 2021-12-11 14:42:36 +01:00
Paul Davis 96b21c4824 fix crash in Playlist::relayer() when there are no regions 2021-12-05 10:36:26 -07:00
Paul Davis 646d1e9a22 remove use of std::numeric_limits<time{pos,cnt}_t> from Playlist
::max() is time-domain dependent, and cannot be encapsulated via a single value.
2021-12-05 09:01:49 -07:00
Robin Gareus d29d40c1ec
Fix stacked region view
Previously this looped endlessly in RegionView::update_coverage_frame()
if the return value was undefined (or wrong time-domain) and smaller
than pos.
2021-12-05 15:05:12 +01:00
Paul Davis 0634dcfbc4 remove some unused code (left over from before RippleAll) 2021-10-29 16:22:30 -06:00
Paul Davis 66b812cc2f remove some unused local variables 2021-10-29 16:22:06 -06:00
Paul Davis cd792f3713 avoid intermediate unnecessary shared_ptr 2021-08-27 17:25:51 -06:00
Paul Davis d772ea3fdf manual post-conflict-resolution cleanups (library edition) 2021-08-13 12:51:36 -06:00
Paul Davis 2330e867b9 remove code no longer required (post-rebase conflict resolution) 2021-08-13 12:51:36 -06:00
Paul Davis d4cfedf6d4 fix duplication of method-scope variable decl 2021-08-13 12:51:36 -06:00
Paul Davis cd1f6269a9 not entirely what this fix is, but i think it is just whitespace (post-rebase conflict resolution) 2021-08-13 12:51:36 -06:00
Paul Davis 5498c433ad fix incorrect lexical scope introduced during rebase conflict resolution 2021-08-13 12:51:36 -06:00
Paul Davis 029fb065b7 fix timeline type issues 2021-08-13 12:51:35 -06:00
Paul Davis 0e264ad2db fix timeline arithmetic operations 2021-08-13 12:51:35 -06:00
Paul Davis 12fb9608d9 fix some timeline type issues 2021-08-13 12:51:35 -06:00
Paul Davis 5f4fa2d9ea fix gap callback argument types at point of use 2021-08-13 12:51:35 -06:00
Paul Davis 0114516c82 add Playlist::remove_gaps() with nutempo timeline types 2021-08-13 12:51:35 -06:00
Paul Davis ba3fc66aa5 cleanup mess from manual rebase against master 2021-08-13 12:51:35 -06:00
Paul Davis f749d4f03e fix rebase issue with positional math (we don't allow " - 1") 2021-08-13 12:51:35 -06:00
Paul Davis 815028752e nutempo #warning removal 2021-08-13 12:51:33 -06:00
Paul Davis 04688292d6 manual fixups for recent rebase conflicts left in the wrong state 2021-08-13 12:51:33 -06:00
Paul Davis 65aa619e58 changes required by fixing ambiguities in timepos_t/timecnt_t API (libs edition) 2021-08-13 12:51:31 -06:00
Paul Davis 82e84e6b92 change all Region::nt_*() methods to names without the nt_ prefix (library version) 2021-08-13 12:51:30 -06:00
Paul Davis eae9d276fe libardour: conversion to use timeline types (mega-commit) 2021-08-13 12:51:29 -06:00
Paul Davis d40bdf5e95 first round of changes to use timeline types, here basically for Region position/length/start
UNFINISHED WORK. Does not compile. But region.cc will compile, hence this snapshot
2021-08-13 12:51:28 -06:00
Paul Davis ecf2028c7a Revert "NO-OP: code formatting and cleanup, thanks clang-format"
Widespread minor changes cause conflicts when rebasing nutempo2; will
reapply formatting later.

This reverts commit 548db7a9a4.
2021-08-13 12:51:28 -06:00
Paul Davis 068cace22c fix semantics of Playlist::find_prev_region_start() 2021-08-13 12:51:28 -06:00
Paul Davis 7e3b22e519 add Playlist::find_prev_region_start() 2021-08-13 12:51:27 -06:00
Paul Davis 46fa558bc6 finalize removal of splicing code from ARDOUR::Playlist 2021-08-13 12:51:27 -06:00
Paul Davis 43c713d0ef we removed Splice mode from the GUI 7 years ago; now remove all code related to Splice mode 2021-08-13 12:51:27 -06:00
Paul Davis a2b3e31e10 libardour: remove ripple callback API, and fix deadlock issues with ripple/ripple_locked/ripple_unlocked/remove_gaps 2021-08-13 12:51:27 -06:00
Paul Davis 815abed5c5 alter API for playlist ripple callback, to provide required information 2021-08-13 12:51:27 -06:00
Paul Davis 447e80a247 add a callback argument to Playlist::ripple() so that the caller can arrange for a response after a single ripple
Also add Playlist::rdiff_and_add_command() to consolidate what is required to save
playlist state in an (undo/redo) Command
2021-08-13 12:51:27 -06:00
Ben Loftis 42d9e88263
Playlist UI Tweaks: assign pgroup_id's on Import (libardour part) 2021-07-03 19:06:03 +02:00
Paul Davis 1734fac410 Revert "Paste Mode: overwrite-paste, naive implementation using rec-mode (for testing)"
This reverts commit f4d4dddbeb.

Deferred until after Ardour 6.8
2021-07-01 18:28:04 -06:00
Ben Loftis f4d4dddbeb Paste Mode: overwrite-paste, naive implementation using rec-mode (for testing) 2021-06-08 08:33:48 -05:00
Ben Loftis c2fb85e37e Cruft removal: behavior of Region List has changed; these functions are deprecated (libardour) 2021-06-08 08:33:48 -05:00
Ben Loftis 0e86e3337c Playlist UI tweaks: relax requirement that playlists names must be unique (libardour part) 2021-06-01 09:39:50 -05:00
Ben Loftis 28aa22e11a Playlist UI tweaks: Add pgroup_id field to playlists, to associate playlists created in the same operation (libardour) 2021-06-01 09:39:50 -05:00
David Robillard 74e21e942e Remove unused variables (Wunused-variable) 2021-05-30 20:09:35 -04:00
Paul Davis 3d15b61e37 fix Playlist::remove_gaps() for ExternalOverlap regions; add per-gap callback 2021-05-28 17:43:33 -06:00
Paul Davis fecce7c333 libardour: initial implementation of Playlist::remove_gaps()
This is probably a little naive and may need extending to cover cross-track scenarios
2021-05-28 12:35:30 -06:00