ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity
39,051 Commits 90 Branches 19 Tags 258 MiB
Commit Graph

24 Commits

Author SHA1 Message Date
Robin Gareus 4b8b5acfc4
Fix builds with gcc-14 lstat (#9703 PR #893) 
from stat(2)
```
lstat():
    /* glibc 2.19 and earlier */ _BSD_SOURCE
        || /* Since glibc 2.20 */ _DEFAULT_SOURCE
        || _XOPEN_SOURCE >= 500
        || /* Since glibc 2.10: */ _POSIX_C_SOURCE >= 200112L

```
 2024-05-07 00:17:56 +02:00
Paul Davis 894e6d27a4 NOOP: whitespace cleanup 2024-04-19 10:43:10 -06:00
Paul Davis c96e12ba58 expand null/destroyed tests for gdk objects in NSView methods 2024-04-19 10:42:59 -06:00
Robin Gareus e64a071e39
(YDK) amend previous commit, call parent method 2024-04-19 16:46:49 +02:00
Robin Gareus 08e394f681
(YDK) possible fix for Catalina event loop crashes 
```
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libydk.dylib 0x0000000110d8942d -[GdkQuartzView setNeedsDisplay:] + 93
1 com.apple.AppKit 0x00007fff34af6848 -[NSView(NSViewContentStyle) _recursivelyInvalidateCachedContentStyle] + 120
2 com.apple.AppKit 0x00007fff34af60fb -[NSView _setSuperview:] + 521
3 com.apple.AppKit 0x00007fff34b200a6 -[NSView removeFromSuperview] + 140
4 com.apple.AppKit 0x00007fff34ba882f -[NSView removeFromSuperviewWithoutNeedingDisplay] + 36
5 com.apple.AppKit 0x00007fff34b27168 -[NSView _finalize] + 977
6 com.apple.AppKit 0x00007fff34b26c0c -[NSView dealloc] + 121
7 com.apple.AppKit 0x00007fff34e30db4 -[NSFrameView dealloc] + 119
8 com.apple.AppKit 0x00007fff34e30d36 -[NSTitledFrame dealloc] + 62
9 com.apple.AppKit 0x00007fff34e30ce9 -[NSThemeFrame dealloc] + 603
10 com.apple.Foundation 0x00007fff39ed5992 NSKVODeallocate + 172
11 com.apple.AppKit 0x00007fff34d85884 -[NSWindow dealloc] + 1083
12 com.apple.AppKit 0x00007fff34d85442 -[NSWindow _dealloc] + 76
13 libobjc.A.dylib 0x00007fff6f6f3054 AutoreleasePoolPage::releaseUntil(objc_object**) + 134
14 libobjc.A.dylib 0x00007fff6f6d7dba objc_autoreleasePoolPop + 175
15 com.apple.CoreFoundation 0x00007fff377c9cb5 _CFAutoreleasePoolPop + 22
16 com.apple.Foundation 0x00007fff39e7d04e -[NSAutoreleasePool drain] + 126
17 libydk.dylib 0x0000000110d8ef29 gdk_event_prepare + 73
18 libglib-2.0.0.dylib 0x00000001110ded45 g_main_context_prepare + 533
19 libglib-2.0.0.dylib 0x00000001110df800 g_main_context_iterate + 128
20 libglib-2.0.0.dylib 0x00000001110dfcc2 g_main_loop_run + 210
21 libytk.dylib 0x0000000110a4f11f gtk_main + 191
22 libgtkmm2ext.dylib 0x00000001104cef1e Gtkmm2ext::UI::run(Receiver&) + 318
23 com.harrisonconsoles.Mixbus10 0x000000010dc6fb9c main + 2652
```
 2024-04-19 15:38:12 +02:00
Robin Gareus fe7fd146aa macOS: fix crash when trying to enter fullscreen while already in fullscreen 
YDK2 uses SetSystemUIMode() for fullscreen. This also uses space
otherwise reserved for the menu bar at the top, and is apparently
preferable for Ardour's UI.

However when a user manually enters fullscreen using the window
title-bar's green button (NSWindow toggleFullScreen). YDK will crash
when the user then also tries to use YDK's fullscreen mode:

```
NSWindowStyleMaskFullScreen cleared on a window outside of a full screen transition.
called from
  [NSWindow setStyleMask:]
  gdk_window_set_decorations
  gdk_window_fullscreen
```

Ideally we'd set NSApp presentation flags so that the toplevel window
would allow one to zoom (maximize), but not to enter fullscreen. Like it
used to be on OSX. It is unclear how to achieve this on macOS for
resizable windows, short of marking the top-level window a dialog or
utility window.
 2024-04-10 20:41:49 +02:00
Robin Gareus ecd22e9aa8 Remove call to deprecated userSpaceScaleFactor 
userSpaceScaleFactor is a missing symbol on some recent versions of macOS.
 2024-04-09 06:06:58 +02:00
Robin Gareus 2e991b0067
Fix thinko in bda7041643 2024-04-04 17:32:50 +02:00
Robin Gareus 3b0e421de4
Use proper _POSIX_C_SOURCE constant 2024-04-04 17:06:31 +02:00
Robin Gareus bda7041643
Fix #9642 - fdopen(3) requires _POSIX_C_SOURCE 
Without this, fdopen() returns some garbage FILE* which
causes a crash when used.
 2024-04-04 17:06:28 +02:00
Paul Davis 6c38e0a4e3 explicitly initialize the needs_display_region member of a GDK quartz window 
This may not be necessary but it is better to have it be explicit
 2024-03-22 13:13:16 -06:00
Paul Davis fe6a635c3a provide a GDK function to enable/disable use of Cocoa-provided rect in drawRect 2024-03-22 13:13:16 -06:00
Paul Davis 7324070628 gdk/quartz: add some additional GDK_NOTE debugging 2024-03-22 13:13:16 -06:00
Robin Gareus da4218c2db
YTK: remove unused code 
This addresses a missing `readlink` due to missing
`_POSIX_C_SOURCE=200809` define when including unistd.h
 2024-03-18 22:02:54 +01:00
Mads Kiilerich a2bb1a3511 Fix more -Wincompatible-pointer-types 
c10154ad23 showed the direction  but was not correct and insufficient
for building with Fedora 40 and gcc 14.0.1 .
 2024-03-18 21:24:46 +01:00
Robin Gareus c10154ad23
Fix a -Wincompatible-pointer-types 2024-03-18 20:29:19 +01:00
Paul Davis 9efd521ea6 (GDK) keep our own record of invalidated rectangles for GdkQuartzView 
macOS has broken its exposure/redraw model at least twice by always providing the entire area
of an NSView for every call to drawRect, and cannot provide the list of rects. This change
expands the tracking done using the needs_display_region, and does so directly via the
objective C methods of an NSView (and its derived children like GdkQuartzView).

The result is that when we send an expose signal, GDK/GTK code can obtain an accurate
list of the invalidated rects if desired, and thus avoiding redrawing the entire contents
of a window
 2024-03-18 10:40:42 -06:00
Robin Gareus 0fa8c5add4
Update ydk-pixbuf, backport upstream changes to io-xpm #9642 
Bastien Nocera <hadess@hadess.net>
  io-xpm: Fix "format not a string literal" errors
  xpm: Sanity check XPM file dimensions
  xpm: Simplify error path
  xpm: Fail when XPM file doesn't contain enough data

Philip Withnall <withnall@endlessm.com>
  io-xpm: Handle fseek() failure

Federico Mena Quintero <federico@gnome.org>
  Use gdk_pixbuf_get_pixels(); don't access the pixels field directly

Tobias Stoeckmann <tobias@stoeckmann.org>
  XPM: Fix undefined behaviour (signed integer overflow)
 2024-02-23 01:29:16 +01:00
Robin Gareus 64e42a465b
YTK is not interested in system-wide GTK Modules 2024-02-23 00:33:17 +01:00
Biswapriyo Nath 7e7d22e7d2
ytk: Fix function pointer casting compiler error with clang 
This fixes the following compiler error.

../libs/tk/ytk/gtkscale.c:1474:50: error: incompatible function pointer types passing
'GCompareFunc' (aka 'int (*)(const void *, const void *)') to parameter of type
'GCompareDataFunc' (aka 'int (*)(const void *, const void *, void *)') [-Wincompatible-function-pointer-types]
    (GCompareFunc) compare_marks,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gslist.h:76:26: note: passing argument to parameter 'func' here
    GCompareDataFunc  func,
    ^
 2024-02-21 13:30:23 +01:00
Martin Vlk d84363329b Czech translation updates. 2024-02-03 21:12:02 +01:00
Robin Gareus ddbe15fd03
Fix gdk livelock on Windows when compiled with recent mingw/gcc 
recent gcc (>=11) sets _WIN32_WINNT >= 0x602 which changes
QS_ALLINPUT to include (QS_TOUCH | QS_POINTER) events which are
only available on Windows 8 and later. Listening to those events
makes ardour unresponsive.
 2024-01-28 21:51:57 +01:00
Robin Gareus 3fc7db08f0
YTK: do no parse gtkrc and theme files 2024-01-14 20:28:43 +01:00
Robin Gareus ad51c7c2ba
Localize stripped down gtk2 
This is intended mainly for GNU/Linux distros who will remove
GTK2 support in the near future.
 2024-01-06 21:52:48 +01:00