Commit Graph

18 Commits

Author SHA1 Message Date
David Runge f331ce7252
Add missing include for iostream, needed for taglib >= 2
Signed-off-by: David Runge <dave@sleepmap.de>
2024-02-20 16:38:37 +01:00
Robin Gareus 35686baa2b
Potential fix for taglib v2.0 crashes when exporting wav
Note that taglib's documentation states that ID3v2Tag()
always returns a valid pointer regardless of whether or not
the file on disk has an ID3v2 tag.
2024-02-17 00:50:54 +01:00
Robin Gareus f0cb8e54c3
Fix taglib error message 2021-04-12 23:15:30 +02:00
Robin Gareus f149a82688
Add support for RIFF and ID3v2 tags (wav, aiff) 2020-11-14 19:30:54 +01:00
Robin Gareus a95d87ef6e
NO-OP: whitespace and private variable-name
This pipes export source-code though clang-format, and some
manual cleanup step.
2020-11-14 17:44:48 +01:00
Robin Gareus a22f918d9d
Update libardour GPL boilerplate and (C) from git log 2019-08-03 15:53:16 +02:00
Robin Gareus 572df2c3bd
NO-OP: add comment for cross-reference 2019-03-26 22:25:20 +01:00
Tim Mayberry 37d76e4104 Use PBD::to_string API from pbd/string_convert.h in AudioFileTagger
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to
remain locale independent and not have to use a LocaleGuard. The formatting is
equivalent.
2017-04-19 09:37:00 +10:00
Robin Gareus 2a0365cbef don't crash if taglib cannot open file 2015-07-28 00:45:09 +02:00
Nils Philippsen 5f00d2f3a7 allow linking unbundled versions of some libraries
(libltc, rubberband, taglib, vamp-sdk)
2013-10-28 09:06:09 +01:00
Robin Gareus bb3690db58 merge Marcel Bonnet's patches for Free-BSD
(may need further cleanup:
 compare with timbyr's windows patch,
 verify fst/vsti + ALSA)

git-svn-id: svn://localhost/ardour2/branches/3.0@13774 d708f5d6-7413-0410-9779-e7cbd77b26cf
2013-01-04 17:36:52 +00:00
Paul Davis 4d112a8e6b remove Glib::ustring from libardour; allow any characters except '/' and '\' in paths (may cause issues when loading creatively named 2.X sessions; fix a couple of details of name collection and usage from the startup dialog
git-svn-id: svn://localhost/ardour2/branches/3.0@7772 d708f5d6-7413-0410-9779-e7cbd77b26cf
2010-09-14 15:45:21 +00:00
David Robillard bb9cc45cd2 Strip trailing whitespace and fix other whitespace errors (e.g. space/tab mixing). Whitespace changes only.
Vimmers, try let c_space_errors = 1 in your .vimrc to highlight this kind of stuff in red.  I don't know the emacs equivalent...


git-svn-id: svn://localhost/ardour2/branches/3.0@5773 d708f5d6-7413-0410-9779-e7cbd77b26cf
2009-10-14 16:10:01 +00:00
David Robillard 906567d867 Use actually normal taglib headers (apparently it completely changes them on install. More idiotically layed out library tree, ever.).
Add symlinks to taglib source tree to mimick installed tree to avoid the copy thing.


git-svn-id: svn://localhost/ardour2/branches/3.0@4674 d708f5d6-7413-0410-9779-e7cbd77b26cf
2009-02-26 03:24:05 +00:00
David Robillard b80aa1fa9d Use normal taglib include paths.
git-svn-id: svn://localhost/ardour2/branches/3.0@4673 d708f5d6-7413-0410-9779-e7cbd77b26cf
2009-02-26 02:48:07 +00:00
David Robillard b4d8dd9613 Use quotes for taglib includes.
git-svn-id: svn://localhost/ardour2/branches/3.0@4672 d708f5d6-7413-0410-9779-e7cbd77b26cf
2009-02-26 02:41:50 +00:00
David Robillard e0aaed6d65 *** NEW CODING POLICY ***
All #include statements that include a header that is a part of a library
bundled with ardour MUST use quotes, not angle brackets.

Do this:

#include "ardour/types.h"

NOT this:

#include <ardour/types.h>

Rationale:

This is best practice in general, to ensure we include the local version
and not the system version.  That quotes mean "local" (in some sense)
and angle brackets mean "system" (in some sense) is a ubiquitous
convention and IIRC right in the C spec somewhere.

More pragmatically, this is required by (my) waf (stuff) for dependencies
to work correctly.  That is:

!!! FAILURE TO DO THIS CAN RESULT IN BROKEN BUILDS !!!

Failure to comply is punishable by death by torture. :)

P.S. It's not that dramatic in all cases, but this (in combination with some
GCC flags specific to the include type) is the best way I have found to be
absolutely 100% positive the local ones are being used (and we definitely
want to be absolutely 100% positive on that one).


git-svn-id: svn://localhost/ardour2/branches/3.0@4655 d708f5d6-7413-0410-9779-e7cbd77b26cf
2009-02-25 18:26:51 +00:00
Paul Davis f2b007195c new files from sakari, missed last time
git-svn-id: svn://localhost/ardour2/branches/3.0@3740 d708f5d6-7413-0410-9779-e7cbd77b26cf
2008-09-17 12:58:33 +00:00