Commit Graph

68 Commits

Author SHA1 Message Date
Paul Davis 40a0ad2299 tweak shortcut window so that the tree is expanded to actually show search results 2023-10-04 17:07:34 -06:00
Robin Gareus e5eafea128
Fix small memory leak
g_file_open_tmp() requires the caller to free the filename.
2023-01-16 05:11:49 +01:00
Paul Davis 2ee80b4eb7 expand everything for a key editor tab is there is only 1 child node 2020-04-17 13:14:34 -06:00
Paul Davis 08d7a8ac3a when binding a key, if it is already bound, offer to replace the existing binding
Telling the user to that first was a bit ... silly.
2020-04-12 08:57:59 -06:00
Robin Gareus 4050ca5633
Update GPL boilerplate and (C)
Copyright-holder and year information is extracted from git log.

git history begins in 2005. So (C) from 1998..2005 is lost. Also some
(C) assignment of commits where the committer didn't use --author.
2019-08-03 15:53:15 +02:00
Paul Davis 3df88accc6 additional logic to avoid showing top-level menu actions in the key shortcut editor 2019-02-16 13:06:08 -07:00
Robin Gareus eb1e423b75 Remove <gtkmm.h> include from header files. 2017-07-17 21:06:04 +02:00
Robin Gareus 008e51ed03 Minor tweak to bindings editor layout 2017-01-12 20:53:20 +01:00
Robin Gareus d36f19ded9 Display name of conflicting keyboard binding 2017-01-12 20:53:20 +01:00
Ben Loftis abe093dcc9 rename Bindings -> Keyboard Shortcuts 2017-01-12 11:51:43 -06:00
Ben Loftis 7b3579bd4d Un-bunch the bunched-up Keybindings editor widgets. 2017-01-05 14:31:27 -06:00
Robin Gareus 9e981367e2 Fix another crash at exit:
Collecting bindings after ::finish() has already destroyed half the GUI
will result in memory corruption invalid Glib::RefPtr<Gtk::Action>

 Gtkmm2ext::ActionMap::get_actions()
 Gtkmm2ext::Bindings::get_all_actions()
 KeyEditor::Tab::populate()
 KeyEditor::refresh()
 Editor::set_script_action_name()
 LuaInstance::session_going_away()
 PBD::Destructible::drop_references()
 ARDOUR::Session::destroy()
 ARDOUR::Session::~Session()
 ARDOUR_UI::finish()
2016-08-21 23:02:37 +02:00
Paul Davis cf52d6e4b4 enough with umpteen "i18n.h" files. Consolidate on pbd/i18n.h 2016-07-14 14:45:23 -04:00
Robin Gareus 265c60126a fix KeyEditor::print() for windows (hopefully, untested) 2016-06-24 22:45:25 +02:00
Paul Davis 321615e8ea initial working version of "printing" keybindings (via a browser) 2016-06-15 19:46:12 -04:00
Paul Davis 66c25b2d73 wording change for key binding dialog remove shortcut button label 2016-06-14 09:53:48 -04:00
Robin Gareus d9c98a51c2 fix windows builds & remove cruft
There's no mkstemp() for windows -> use Glib::file_open_tmp()
also ofstream should not be used (on windows it does not support UTF8 fn)
strstream + Glib::file_set_contents ()
2016-06-01 12:01:25 +02:00
Paul Davis eaddf752c7 hacked up incomplete use of print-key-bindings-as-html 2016-05-31 15:30:44 -04:00
Robin Gareus 55fb20f491 update keyeditor when action label changes 2016-04-24 22:20:44 +02:00
Mathias Buhr 1316e85d41 Don't crash when keyeditor is empty 2016-03-30 07:29:09 -04:00
Paul Davis a06a5ecfd6 change the way the key editor gets populated; drop binding sets with no actions 2016-03-15 19:46:28 -04:00
Paul Davis 694c7254e1 in key editor, attach key press/release handlers before other handlers so that normal treeview navigation keys (backspace, up, down etc.) can still be bound 2016-03-15 18:15:26 -04:00
Paul Davis f83a7f4131 extend API of key binding editor to allow for tab removal 2016-03-15 16:42:45 -04:00
Mathias Buhr 720c68d7e1 Adds a tooltip to the icon 2016-03-08 08:44:58 -05:00
Mathias Buhr 1375c454fb Implements filtering in bindings editor 2016-03-08 08:44:58 -05:00
Paul Davis 6aa7ca6d70 edited keybindings should be stored in lower-case form 2016-03-05 11:53:42 -05:00
Paul Davis b4ead1dda6 remove some uncharacteristic comments in code 2016-03-05 11:53:20 -05:00
Mathias Buhr 290d9e5e66 Small refactoring of keyboard bindings (first part)
- Adds collision detection for keybindings
- Fixes a bug that prevented newly created bindings to be deleted properly (reproduction: add a binding, remove it, restart ardour, binding is still there but can now be deleted).
2016-03-05 16:27:48 +01:00
Mathias Buhr 0a8b99fe6c Adds sorting the toe keyeditor 2016-03-05 16:27:48 +01:00
Paul Davis 6991a07902 remove all trace of SAE from source code.
This had become incoherent over time, and posed a development hazard and burden going forward
2016-02-22 15:31:24 -05:00
Paul Davis bc487bb4b0 replicate the remove-all-trailing whitespace commit(s) in master 2016-02-22 15:31:24 -05:00
Paul Davis 6e55812535 use Bindings API for binding replacement 2016-02-22 15:31:23 -05:00
Paul Davis e35e26fa9b redesign key editor to work with tabbed notebook, one tab per set of bindings 2016-02-22 15:31:23 -05:00
Robin Gareus 22b07e0233 NOOP, remove trailing tabs/whitespace. 2015-10-05 16:17:49 +02:00
nick_m 35f69656e8 Window focus handling fixes.
Many windows were not getting key events.
Use magic focus infrastructure (built for widgets) to deliver key events
via window focus in/out.
2015-04-02 02:41:49 +11:00
David Robillard 4166b05bda Fix setting command key bindings on OSX. 2015-01-14 20:31:38 -05:00
David Robillard 2ef8c06464 Redisplay key bindings when reset. 2015-01-07 21:02:13 -05:00
Paul Davis 4453803c0c This fixes a bug where an impossible keybinding assignment is possible.
It also makes it behave similar to the gtk keybinder. See Bug 5888 for more
details. From pull request #82 @ github, from Domohawk
2014-12-18 11:14:41 -05:00
Paul Davis c39666dc5c fix key editor resize behaviour 2014-07-10 11:53:39 -04:00
Paul Davis d324f67cce add reset bindings button to key bindings editor 2014-07-10 11:04:24 -04:00
Robin Gareus a3c378cf62 move utility functions into a dedicated namespace 2014-06-25 21:47:54 +02:00
Paul Davis 20fa19e69e more excision of "JACK" from labels, menu items, etc.
NOTE: users will lose the sample rate/latency display in the status bar display. Not yet sure what to do about this
2013-09-17 22:25:21 -04:00
Paul Davis a26827d3b7 fix a SNAFU that occured when switch from ArdourDialog to ArdourWindow that removed the "Rmove shortcut" button from the keyeditor
git-svn-id: svn://localhost/ardour2/branches/3.0@13079 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-07-25 00:32:59 +00:00
Tim Mayberry 22e478e7fc Remove unneeded header include
git-svn-id: svn://localhost/ardour2/branches/3.0@12828 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-06-23 03:51:43 +00:00
David Robillard 6fa6514cfd Remove over 500 unnecessary includes (including 54 of session.h).
It's slightly possible that this causes trivial build failures on different
configurations, but otherwise shouldn't cause any problems (i.e. no actual
changes other than include/naming/namespace stuff).  I deliberately avoided
removing libardour-config.h since this can mysteriously break things, though a
few of those do seem to be unnecessary.

This commit only targets includes of ardour/*.h.  There is also a very large
number of unnecessary includes of stuff in gtk2_ardour; tackling that should
also give a big improvement in build time when things are modified.


git-svn-id: svn://localhost/ardour2/branches/3.0@12420 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-05-24 06:09:29 +00:00
Paul Davis 8d5065bc32 remove, convert, comment several cerr statements
git-svn-id: svn://localhost/ardour2/branches/3.0@12378 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-05-22 12:57:05 +00:00
Paul Davis 69830c477e MCP: catch noteOff to see note-on+velocity=zero messages; more GUI tweaks
git-svn-id: svn://localhost/ardour2/branches/3.0@11966 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-04-13 21:46:26 +00:00
Ben Loftis b4999fbc14 remove menu items from the keybindings dialog
git-svn-id: svn://localhost/ardour2/branches/3.0@11654 d708f5d6-7413-0410-9779-e7cbd77b26cf
2012-03-12 19:24:16 +00:00
Paul Davis 678c41d05f remove OS X specific code for key editor binding displays
git-svn-id: svn://localhost/ardour2/branches/3.0@10895 d708f5d6-7413-0410-9779-e7cbd77b26cf
2011-12-04 22:32:48 +00:00
Paul Davis 97d74666e9 lets see what gtk/osx displays for key bindings without us editing them
git-svn-id: svn://localhost/ardour2/branches/3.0@10894 d708f5d6-7413-0410-9779-e7cbd77b26cf
2011-12-04 22:03:52 +00:00