Commit Graph

80 Commits

Author SHA1 Message Date
jean-emmanuel 8a4f852ff2
ui: mixer: same as 313b0b2ddd but with label button 2024-02-15 14:58:46 +01:00
jean-emmanuel 313b0b2ddd
ui: mixer: clear strip selection when clicking on foldback bus number label, otherwise changing the bus' color will also affect whatever strip is currently selected (this is a more general issue however and should probabaly be addressed globally) 2024-02-15 14:56:22 +01:00
jean-emmanuel ef160dd24e
mixer: ui: consistent interaction with foldback bus number label (context menu on press instead of release) 2024-02-15 14:56:21 +01:00
Robin Gareus 9cc966120c
Consolidate internal bus checks (2/2) 2024-01-06 20:21:54 +01:00
Robin Gareus de7d0a986b
Foldback: fix memory leak 2023-11-29 02:20:09 +01:00
Paul Davis b35518e212 switch from boost::{shared,weak}_ptr to std::{shared,weak}_ptr
This is mostly a simple lexical search+replace but the absence of operator< for
std::weak_ptr<T> leads to some complications, particularly with Evoral::Sequence
and ExportPortChannel.
2023-03-24 14:19:15 -06:00
Robin Gareus 16a476ee5f
Fix foldback bus duplication
signal_sources() can traverse upwards. e.g. when creating a
foldback send to the master-bus, everything that feeds the master
also feeds the foldback (even if there is no direct send).
2023-01-04 04:00:36 +01:00
Robin Gareus 109e7d6ea0 When editig sends, show the send's polarity control on mixer-strip 2022-09-04 20:25:51 +02:00
Ben Loftis 8f9ad771b3
Display the dB value in foldback return slider 2022-08-05 01:27:57 +02:00
Ben Loftis cef0e5d518
Define a theme-able color for foldback return widgets 2022-08-05 01:26:28 +02:00
Robin Gareus 5834728e2f
Allow to un/link foldback send panners 2022-08-05 00:56:19 +02:00
Robin Gareus 9b1440ab23
Use new Route fed-by API (1/2) 2022-05-06 14:02:35 +02:00
Robin Gareus f2016f2408
Prepare for GraphNode::feeds () and fed-by API update (1/2) 2022-05-06 14:02:34 +02:00
Mads Kiilerich 7f649efd42
gtkmm: use set_can_focus() instead of deprecated Gtk::Widget::set_flags(CAN_FOCUS) 2022-04-08 21:11:06 +02:00
Robin Gareus 2ed8fd2723
Pixel-pushing: vertically align special busses
The mixer's track area has a border with shadow (again).
This breaks vertical alignment with monitor-section,
master, foldback busses.
2021-04-03 22:27:05 +02:00
Robin Gareus 98c55abdfe
Foldback: fix removing last fb bus
This also reverts a RouteUI change to handle set_route(NULL)
from ce28065421.

The RouteUI already calls self_delete() when DropReferences
is emitted.
2021-03-30 01:48:46 +02:00
Robin Gareus e4f59d9a4d
Foldback: update button sensitivity when sends or fb's change 2021-03-28 20:11:34 +02:00
Robin Gareus bfc72ac379
Fix 32bit builds (missing size_t string convert)
../libs/pbd/pbd/string_convert.h: In function 'std::string PBD::to_string(T) [with T = long unsigned int]':
../gtk2_ardour/foldback_strip.cc:581:   instantiated from here
../libs/pbd/pbd/string_convert.h:238: error: 'long unsigned int' is not a class, struc
2021-03-28 05:45:20 +02:00
Robin Gareus 9c4a8ba528
Foldback: GUI consistency
* Insensitive route-ops menu when track disabled
* Re-order route-ops to match mixer-strip
* Add number Label to foldbacks
* Set spacing for consistent look/feel
2021-03-27 23:14:19 +01:00
Robin Gareus bf8f0efbf9
Foldback: Cont'd tweaks and fixes
* Follow track order changes
* Show send context menu on right-click
* use "route_connections" for route signals
2021-03-27 19:33:46 +01:00
Robin Gareus 294b550584
Trap click signals of inline-controls
RouteUI::show_sends_press() is re-used used to show
the send context menu. However other button actions
need to be ignored.
2021-03-27 18:47:01 +01:00
Robin Gareus c91080e950
NO-OP: cosmetic changes
* Prefix private member variable with underscores.
* use C-style comment blocks
* Inline single-use method
2021-03-27 18:31:10 +01:00
Robin Gareus 602135ad66
Foldback: Remove shadowed session-variable, RouteUI is-a SessionHandlePtr 2021-03-27 18:24:39 +01:00
Robin Gareus ac5bca4a92
Clean up RouteUI header
* Consolidate access modifiers
* Remove all public member variables
* Only expose required functions, use private
  whenever possible
* Rename private members, prefix underscore
* Remove cruft
2021-03-27 17:44:34 +01:00
Robin Gareus 003be3d87e
Localize private variable (only used by RouteUI) 2021-03-27 16:25:30 +01:00
Robin Gareus 24499fa7da
Foldback: use RouteUI send-spill functions
This resolves ambiguities of overloaded non-virtual methods
that used shared protected variables (send_blink_connection).

It fixes "show sends" of foldback busses (spilling the send
controls) and allows for showing showing other sends directly
without first disabling it.

This fixes some related issues with inheritance and
signal propagation.
2021-03-27 15:52:14 +01:00
Robin Gareus 212b08b422
Foldback: remove unused processor actions
Also since foldback-busses are not selectable AxisViews,
various keyboard-shortcut operations cannot be performed
from the mixer-context. However the processox-box itself
provides these actions for the fold-back bus.
2021-03-26 23:52:12 +01:00
Robin Gareus a94c0d62a6
Foldback: Con't work to remove unused mixer-strip code 2021-03-26 23:49:36 +01:00
Robin Gareus 0edb6083f1
Foldback strip: remove cruft
Remove unused code that was copy/pasted from mixer_strip.cc
which is not needed for foldback strips. Notably alternative
delivery display mode (aux-sends).
2021-03-26 16:39:40 +01:00
Robin Gareus 05f6550e2c
Foldback: NO-OP clang-format 2021-03-26 02:48:04 +01:00
Robin Gareus 01bc039f9b
Foldback: use IObutton
This follows 3e7b2bb3f5, common shared implementation
of IOButtons. This also uses RouteUI provided IOSelectorWindows.
2021-03-26 02:33:56 +01:00
Robin Gareus b12cad80bc
Foldback: consistent mouse handling part 1
* un-hardcode button numbers, use portable modifier API
* allow to toggle Send bypass with middle-click
* add support for delete-operator
* Only act on single-click press
2021-03-26 02:17:09 +01:00
Robin Gareus ce28065421
Foldback: refactor spill logic
Prefer to reuse spill logic from the mixer-ui.
This allows to spill routes directly after spilling
foldbacks. Previously that resulted in FB "show sends"
to keep flashing even then no foldbacks were spilled anymore.

It also simplifies various aspects of foldback prev/next
logic.
2021-03-25 21:38:10 +01:00
Robin Gareus c3fb344f44
Foldback: spill follows selection 2021-03-25 14:39:46 +01:00
Robin Gareus aacfc0704d
Add A/PFL button to foldback strip 2021-03-24 17:48:22 +01:00
Robin Gareus 9b4d330285
Remove unused variable
`ignore_toggle` is never set to true.
2021-01-29 02:58:25 +01:00
Robin Gareus b2c4e71a45
Subscribe to pretty-port name changes (GUI) 2021-01-18 03:18:20 +01:00
Len Ovens dde2ebdcb3 Add menu item per send to change pre/post fader 2020-08-09 09:10:24 -07:00
Len Ovens 0a4dddc072 Make duplicate foldback bus copy pre/postfader positon 2020-08-08 21:29:09 -07:00
Len Ovens 855b5c5522 Add foldback to selected tracks now pre or post fader 2020-08-08 21:16:33 -07:00
Len Ovens 9d1ff57b58 Change FB GUI to show pre/post foldback with right color 2020-08-08 18:43:06 -07:00
Len Ovens 5c6e8954ed Add pre/post fader to foldback send creation
add position param to send creation
	default all to prefader as first step
2020-08-08 18:41:03 -07:00
Len Ovens b8202431ef Add foldback bus dulication option
Duplicates the bus and its sends and levels
2020-05-28 07:05:59 -07:00
Robin Gareus d91189ffe5
Consistent GPL boilerplate 2020-05-08 03:19:17 +02:00
Len Ovens 7a5dc98296 Fix gpl address 2020-05-07 17:34:49 -07:00
Len Ovens 8e1e271eba Add a meter to Foldback bus
Spaces got replaced by tabs as well.
2020-05-07 17:13:40 -07:00
Len Ovens deca562108 Use sorted list of foldback buses
previous and next would not always allow
	getting to all buses which were in an odd order
	depending on how they are added
2020-05-05 19:42:31 -07:00
Len Ovens feb689d220 Fix issue 8087 menu build when only one bus
If there is only one Foldback bus:
	the selection button still respond to left click.
	Any other click on the same button will need two
	clicks
2020-05-05 11:42:45 -07:00
Len Ovens 2df52979d4 The listen Button (Solo) has no function in Foldback remove 2020-05-05 09:21:50 -07:00
Robin Gareus 4bd90dec5f
Initialize uninitialized variable (show foldback sends) 2020-04-20 00:48:54 +02:00