Commit Graph

25 Commits

Author SHA1 Message Date
Mads Kiilerich a9e5876207
Minor clarification of curl root CA comment
Left over from d069aa7a.
2022-11-04 19:18:54 +01:00
Mads Kiilerich fac5228e50
Add hint that the Mozilla CA list could be bundled
That would in my opinion be a very fine fall back if detection of the
system CA store fails.
2022-10-24 04:47:42 +02:00
Mads Kiilerich 47b7b98652
Clarify that ca_info files must exist as files
From file_test documentation:
  Returns TRUE if any of the tests in the bitfield test are TRUE.

A Glib::file_test parameter like
  Glib::FILE_TEST_EXISTS|Glib::FILE_TEST_IS_REGULAR
will thus also return true if the path exist as a directory.

Make the code work as intended by simply using
Glib::FILE_TEST_IS_REGULAR
2022-10-24 04:47:41 +02:00
Mads Kiilerich d069aa7a56
Use default ca_path /etc/ssl/certs on all systems #9005
This fixes the problem of the invalid /nonexistent_path path making all
certificate validation fail on Fedora. /etc/ssl/certs only recently
started working like on Debian, but it is enough that ca_info works, as
long as /etc/ssl/certs exists and doesn't make cert validation fail.
2022-10-24 04:47:41 +02:00
Mads Kiilerich f8ce185205
Revert "Disable cert check if no SSL certs are found (#9005)"
This reverts commit 073d6f5e80.
2022-10-24 04:47:41 +02:00
Mads Kiilerich 06b503d716
Revert "Another attempt for ssl-cert support on RHEL/Fedora #9005"
This reverts commit b75be7f975.
2022-10-24 04:47:41 +02:00
Robin Gareus b75be7f975
Another attempt for ssl-cert support on RHEL/Fedora #9005
When /etc/pki/tls/certs/ca-bundle.crt exists, jus use
that file and do not set any PATHs. Disable default
built-in /etc/ssl/certs
2022-10-19 18:23:03 +02:00
Robin Gareus 073d6f5e80
Disable cert check if no SSL certs are found (#9005) 2022-10-18 19:37:06 +02:00
Paul Davis 02b77ca88a better fix for CURL debugging unused variable warning 2022-06-21 17:36:26 -06:00
Paul Davis 5bc7c26d9b fix unused variable errors 2022-06-21 17:32:09 -06:00
Robin Gareus 3caa58ba78
ArdourHttp, export API to set CA paths
Ideally all https requests would pass via ArdourCurl, instead
of custom libcurl usage, but that will require some major refactoring
2022-05-20 22:03:13 +02:00
Robin Gareus b553b67407
Fix curl free() ambiguity - fixes windows issues
curl_free() is to be used for data allocated by
curl_easy_escape() or curl_easy_unescape() in libcurl.

This is unrelated to realloc/free in WriteMemoryCallback().
2021-02-28 15:17:30 +01:00
Robin Gareus c69dde96eb
Ardour HTTPS verify that peer isn't lying about the cert
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYHOST.html
2020-10-30 15:58:04 +01:00
Robin Gareus 6987196ea1
More i18n include order fixes 2019-09-26 06:11:30 +02:00
Robin Gareus 4050ca5633
Update GPL boilerplate and (C)
Copyright-holder and year information is extracted from git log.

git history begins in 2005. So (C) from 1998..2005 is lost. Also some
(C) assignment of commits where the committer didn't use --author.
2019-08-03 15:53:15 +02:00
Paul Davis f448041ec0 no error logging for CURL HTTP requests; future callers can request it if necessary 2018-06-02 13:24:31 -04:00
Paul Davis 1e5813cf18 no actual error messages when curl requests fail 2018-05-23 23:08:13 -04:00
Robin Gareus 4f82d1ba99 No need for memset to clear a byte. 2017-11-23 10:10:32 +01:00
Robin Gareus 511216a587 Disable ArdourHTTP debug 2017-09-01 00:36:19 +02:00
Robin Gareus 841bbca773 print debugging for macOS/curl issues 2017-08-31 20:45:51 +02:00
Robin Gareus e544934780 Call curl_global_init() exactly only once (1/2) 2017-08-31 20:08:47 +02:00
Robin Gareus 720292696a Fix ArdourHTTP error reporting 2017-08-31 19:21:43 +02:00
Robin Gareus 0996656ecc Allow to query HTTP headers 2016-09-16 01:39:04 +02:00
Robin Gareus c9959f742a clean up HttpGet 2016-07-18 19:21:05 +02:00
Robin Gareus 004b57e9f6 ArdourCurl: prepare to unify various curl calls
mainly motivated by a central location to setup SSL.
2016-07-18 16:46:59 +02:00