ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Groups created from the (edit,mix) windows should share the same default properties. 

In the past, we chose different defaults in homage to ardour's old mix/edit groups.
But that wasn't a very good idea.
For now they have all properties enabled and the user can disable them as-needed.
It might also be nice to make the user's property selections perist for new groups.
This commit is contained in:
Ben Loftis 2015-03-10 15:54:54 -05:00
parent a2b35aa634
commit f214488d0f
6 changed files with 21 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gtk2_ardour/editor_group_tabs.cc
View File

@ -177,19 +177,6 @@ EditorGroupTabs::add_menu_items (Gtk::Menu* m, RouteGroup* g)
}
}
PBD::PropertyList
EditorGroupTabs::default_properties () const
{
PBD::PropertyList plist;
plist.add (Properties::active, true);
plist.add (Properties::mute, true);
plist.add (Properties::solo, true);
plist.add (Properties::recenable, true);
return plist;
}
RouteList
EditorGroupTabs::selected_routes () const
{

1
gtk2_ardour/editor_group_tabs.h
View File

@ -36,7 +36,6 @@ private:
return get_height();
}
void add_menu_items (Gtk::Menu *, ARDOUR::RouteGroup *);
PBD::PropertyList default_properties () const;
ARDOUR::RouteList selected_routes () const;
void sync_order_keys ();
};

20
gtk2_ardour/group_tabs.cc
View File

@ -395,6 +395,26 @@ GroupTabs::new_from_soloed ()
run_new_group_dialog (soloed);
}
PBD::PropertyList
GroupTabs::default_properties () const
{
PBD::PropertyList plist;
plist.add (Properties::route_active, true);
plist.add (Properties::active, true);
plist.add (Properties::gain, true);
plist.add (Properties::relative, true);
plist.add (Properties::color, true);
plist.add (Properties::monitoring, true);
plist.add (Properties::select, true);
plist.add (Properties::mute, true);
plist.add (Properties::solo, true);
plist.add (Properties::gain, true);
plist.add (Properties::recenable, true);
return plist;
}
void
GroupTabs::run_new_group_dialog (RouteList const & rl)
{

2
gtk2_ardour/group_tabs.h
View File

@ -91,7 +91,7 @@ private:
virtual double extent () const = 0;
virtual void add_menu_items (Gtk::Menu *, ARDOUR::RouteGroup *) {}
virtual PBD::PropertyList default_properties () const = 0;
virtual PBD::PropertyList default_properties () const;
virtual ARDOUR::RouteList selected_routes () const = 0;
virtual void sync_order_keys () = 0;

14
gtk2_ardour/mixer_group_tabs.cc
View File

@ -170,20 +170,6 @@ MixerGroupTabs::routes_for_tab (Tab const * t) const
return routes;
}
PropertyList
MixerGroupTabs::default_properties () const
{
PropertyList plist;
plist.add (Properties::active, true);
plist.add (Properties::mute, true);
plist.add (Properties::solo, true);
plist.add (Properties::gain, true);
plist.add (Properties::recenable, true);
return plist;
}
RouteList
MixerGroupTabs::selected_routes () const
{

1
gtk2_ardour/mixer_group_tabs.h
View File

@ -35,7 +35,6 @@ private:
return get_width();
}
PBD::PropertyList default_properties () const;
ARDOUR::RouteList selected_routes () const;
void sync_order_keys ();