ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Remove Region::position remnants (see cc6c0f1263)

Browse Source
This commit is contained in:
Robin Gareus 2022-03-04 22:38:41 +01:00
parent 1462590ace
commit ecb1d33c02
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
8 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libs/ardour/ardour/region.h
View File

@ -64,7 +64,6 @@ namespace Properties {
LIBARDOUR_API extern PBD::PropertyDescriptor<bool> valid_transients;
LIBARDOUR_API extern PBD::PropertyDescriptor<timepos_t> start;
LIBARDOUR_API extern PBD::PropertyDescriptor<timecnt_t> length;
LIBARDOUR_API extern PBD::PropertyDescriptor<timepos_t> position;
LIBARDOUR_API extern PBD::PropertyDescriptor<timepos_t> sync_position;
LIBARDOUR_API extern PBD::PropertyDescriptor<layer_t> layer;
LIBARDOUR_API extern PBD::PropertyDescriptor<timepos_t> ancestral_start;

1
libs/ardour/audio_playlist.cc
View File

@ -358,7 +358,6 @@ AudioPlaylist::region_changed (const PropertyChange& what_changed, boost::shared
PropertyChange bounds;
bounds.add (Properties::start);
bounds.add (Properties::position);
bounds.add (Properties::length);
PropertyChange our_interests;

2
libs/ardour/filter.cc
View File

@ -143,13 +143,13 @@ Filter::finish (boost::shared_ptr<Region> region, SourceList& nsrcs, string regi
plist.add (Properties::length, region->length());
plist.add (Properties::name, region_name);
plist.add (Properties::whole_file, true);
plist.add (Properties::position, region->position());
boost::shared_ptr<Region> r = RegionFactory::create (nsrcs, plist);
boost::shared_ptr<AudioRegion> audio_region = boost::dynamic_pointer_cast<AudioRegion> (region);
boost::shared_ptr<AudioRegion> audio_r = boost::dynamic_pointer_cast<AudioRegion> (r);
if (audio_region && audio_r) {
audio_r->set_position (region->position());
audio_r->set_scale_amplitude (audio_region->scale_amplitude());
audio_r->set_fade_in_active (audio_region->fade_in_active ());
audio_r->set_fade_in (audio_region->fade_in ());

1
libs/ardour/globals.cc
View File

@ -575,7 +575,6 @@ ARDOUR::init (bool try_optimization, const char* localedir, bool with_gui)
*/
bounds_change.add (ARDOUR::Properties::start);
bounds_change.add (ARDOUR::Properties::position);
bounds_change.add (ARDOUR::Properties::length);
/* provide a state version for the few cases that need it and are not

1
libs/ardour/import.cc
View File

@ -575,7 +575,6 @@ Session::deinterlace_midi_region ( boost::shared_ptr<MidiRegion> mr )
PropertyList plist;
plist.add (Properties::whole_file, true);
plist.add (Properties::start, mr->start());
plist.add (Properties::position, mr->position());
plist.add (Properties::length, mr->length());
plist.add (Properties::name, (*x)->name());
plist.add (Properties::tags, "(split-chans)");

1
libs/ardour/import_pt.cc
View File

@ -312,7 +312,6 @@ Session::import_pt_rest (PTFFormat& ptf)
PropertyList plist;
plist.add (ARDOUR::Properties::start, timepos_t (a->sampleoffset));
plist.add (ARDOUR::Properties::position, timepos_t (0));
plist.add (ARDOUR::Properties::length, a->length);
plist.add (ARDOUR::Properties::name, a->name);
plist.add (ARDOUR::Properties::layer, 0);

2
libs/ardour/lua_api.cc
View File

@ -1231,7 +1231,6 @@ LuaAPI::Rubberband::finalize ()
plist.add (Properties::length, _region->length_samples ());
plist.add (Properties::name, region_name);
plist.add (Properties::whole_file, true);
plist.add (Properties::position, _region->position_sample ());
boost::shared_ptr<Region> r = RegionFactory::create (sl, plist);
boost::shared_ptr<AudioRegion> ar = boost::dynamic_pointer_cast<AudioRegion> (r);
@ -1245,6 +1244,7 @@ LuaAPI::Rubberband::finalize ()
ar->set_ancestral_data (timepos_t (_read_start), timecnt_t (_read_len), _stretch_ratio, _pitch_ratio);
ar->set_master_sources (_region->master_sources ());
ar->set_position (timepos_t (_region->position_sample ()));
ar->set_length (ar->length () * _stretch_ratio); // XXX
if (_stretch_ratio != 1.0) {
// TODO: apply mapping

1
libs/ardour/region.cc
View File

@ -73,7 +73,6 @@ namespace ARDOUR {
PBD::PropertyDescriptor<timecnt_t> length;
PBD::PropertyDescriptor<double> beat;
PBD::PropertyDescriptor<timepos_t> sync_position;
PBD::PropertyDescriptor<timepos_t> position;
PBD::PropertyDescriptor<layer_t> layer;
PBD::PropertyDescriptor<timepos_t> ancestral_start;
PBD::PropertyDescriptor<timecnt_t> ancestral_length;