Clamp output of y_to_note so that it doesn't return out-of-range values. Should fix #3823.

git-svn-id: svn://localhost/ardour2/branches/3.0@9096 d708f5d6-7413-0410-9779-e7cbd77b26cf

gtk2_ardour/midi_streamview.cc

@@ -628,3 +628,17 @@ MidiStreamView::update_rec_box ()
 	mrv->extend_active_notes ();
 }
 
+uint8_t
+MidiStreamView::y_to_note (double y) const
+{
+	int const n = ((contents_height() - y - 1) / contents_height() * (double)contents_note_range())
+		+ lowest_note();
+
+	if (n < 0) {
+		return 0;
+	} else if (n > 127) {
+		return 127;
+	}
+	
+	return n;
+}

gtk2_ardour/midi_streamview.h

@@ -83,10 +83,7 @@ class MidiStreamView : public StreamView
 		{ return contents_height()
 			- (note + 1 - lowest_note()) * note_height() + 1; }
 
-	inline uint8_t y_to_note(double y) const
-		{ return (uint8_t)((contents_height() - y - 1)
-				/ contents_height() * (double)contents_note_range())
-				+ lowest_note(); }
+	uint8_t y_to_note(double y) const;
 
 	inline double note_height() const
 		{ return contents_height() / (double)contents_note_range(); }