From dec92821103745fa000122348a23a5a0b17013b9 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Tue, 31 Oct 2023 09:56:05 -0600 Subject: [PATCH] midisurface: use correct virtual method for note off This likely needs checking for all surfaces that inherit from MidiSurface. It is clearly the correct thing to have in the code, but existing behavior might be predicated on the former incorrect connection --- libs/ctrl-interface/midi_surface/midi_surface.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/ctrl-interface/midi_surface/midi_surface.cc b/libs/ctrl-interface/midi_surface/midi_surface.cc index c50235ccfa..12e6391e4a 100644 --- a/libs/ctrl-interface/midi_surface/midi_surface.cc +++ b/libs/ctrl-interface/midi_surface/midi_surface.cc @@ -379,7 +379,7 @@ MIDISurface::connect_to_port_parser (MIDI::Port& port) /* Button messages are NoteOn */ p->note_on.connect_same_thread (*this, boost::bind (&MIDISurface::handle_midi_note_on_message, this, _1, _2)); /* Button messages are NoteOn but libmidi++ sends note-on w/velocity = 0 as note-off so catch them too */ - p->note_off.connect_same_thread (*this, boost::bind (&MIDISurface::handle_midi_note_on_message, this, _1, _2)); + p->note_off.connect_same_thread (*this, boost::bind (&MIDISurface::handle_midi_note_off_message, this, _1, _2)); /* Fader messages are Pitchbend */ p->channel_pitchbend[0].connect_same_thread (*this, boost::bind (&MIDISurface::handle_midi_pitchbend_message, this, _1, _2));